Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small regression test to -wrap-flow property testing #853

Merged
merged 2 commits into from
Mar 14, 2013

Conversation

zhorvath
Copy link
Contributor

We need to extend the wrap-flow testing with a small regression test to get the accurate result. Testing only the property parsing is not enough anymore.

@stucox
Copy link
Member

stucox commented Mar 11, 2013

Do we need this? Unless there's proof of a browser giving a false positive with the standard detect, we try to go for the simplest (and hence fastest) detect we can.

@paulirish
Copy link
Member

if it IS necessary then lets document in the code why. Thanks for your help on this detect, @zhorvath

@zhorvath
Copy link
Contributor Author

Unfortunately, yes. We parse the property in WebKit, but we haven't got the implementation for the wrap-flow yet, so the original test case is false+ for WebKit.

@paulirish: I'm going to add a comment to the code.

@paulirish
Copy link
Member

@zhorvath how does CSS.supports() fair with wrapFlow:end ?

@zhorvath
Copy link
Contributor Author

@paulirish: sorry, I don't know what CSS.supports() is. Could you send me a pointer to it?

@stucox
Copy link
Member

stucox commented Mar 11, 2013

CSS.supports = native feature detection — spec

It's only implemented in FirefoxAurora and Opera at the moment, neither of which support wrap-flow.

@myakura
Copy link
Contributor

myakura commented Mar 12, 2013

CSS.supports() is implemented in WebKit, but both Safari and Chromium hasn't enabled the build flag...

@zhorvath
Copy link
Contributor Author

So, do you like this pull request? :)

@stucox
Copy link
Member

stucox commented Mar 14, 2013

Yep, cheers. I take it it's still true in IE10?

@zhorvath
Copy link
Contributor Author

Yes. I tested with the latest public IE10.

stucox pushed a commit that referenced this pull request Mar 14, 2013
Add a small regression test to -wrap-flow property testing
@stucox stucox merged commit 6425a32 into Modernizr:master Mar 14, 2013
@stucox
Copy link
Member

stucox commented Mar 14, 2013

Nice one, thanks. LGTM.

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Add a small regression test to -wrap-flow property testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants