Use margin instead of width to test for :change pseudo-selector #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if we should apply Thoughts? |
|
Yeah makes sense to do that. |
|
As suggested - updated this pull request, let me know if you have any other suggestions, cheers! |
|
Nice one, thanks Tom. |
stucox
pushed a commit
that referenced
this pull request
May 20, 2013
Use margin instead of width to test for :change pseudo-selector
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Use margin instead of width to test for :change pseudo-selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox it's not possible to adjust the width/height of the checkbox using css, hence the test would fail while support for :checked obviously exists. I suggest using
margin-leftand measuringoffsetLeftinstead, code attached.