Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Filing a bug
Clone this wiki locally
In order for the team to better fix issues we request that you include the following information that can help us diagnose and fix the problem:
- Confirm it's still an issue with the latest version from the download page.
- Include a link to the exact build you're using.
- Explain if your issue is browser specific, and which browsers (incl. versions) it affects
- Create a reduced testcase; this helps a huge amount!
- Use jsfiddle or codepen if you want.
We can never have too much detail, so include as much info as you can. Have a look at issue #501 for a great example that ticks all the boxes.
A feature test that passes in a browser that should fail is a bad thing for everyone. :( You can help in a few ways.
- First, file a ticket on modernizr's issue tracker. It'll be tagged as "false result".
- Report the false positive as a bugs to their corresponding browser vendors. Many times its a mobile port of WebKit that has a the problem, while it may not exist in other WebKit ports. You can file these at the WebKit tracker regardless.
- Write a pull request to fix the feature detect. Sometimes the false positive can be worked around (by forcing a reflow, adding the element to the DOM, etc)… as a last result we will add a UA sniff.
- Add to the .js file some metadata that declares what browsers are false positiving here.
We expect to have an overview page later on with all false positives, for easy reading. More importantly, though, Modernizr will strive to report accurately, even if the browser is returning a false positive for the correct detect.
We agree that browser bugs should be detected instead of assumed for given UA strings. This is how
jQuery.support works. However Modernizr detects features and will not be collecting bugs (like
box-sizing doesn't work with
min-height in Firefox). We do recommend you file the issue with the appropriate vendor and blog about it or post on Stack Overflow to get the word out there with your proposed fix.