Make map codecs more resistant to erroring entries. Fixes MC-197860 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ap5ud5
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Looks good. I can confirm this change does indeed fix MC-19786.
I will link some of my findings made for the Forge version fix:
- Minecraft already forces player to overworld if dimension is missing
- PR preserves vanilla dimensions
- PR also preserves working custom dimensions
More information about the testing process and related files:
https://drive.google.com/file/d/1TNqRLxnF9YVujFEvU3STZPzDwUuTUo0-/view?usp=drivesdk
TelepathicGrunt
approved these changes
Jan 16, 2021
Pepe20129
approved these changes
Jan 16, 2021
ix0rai
approved these changes
Jan 17, 2021
liach
suggested changes
Jan 30, 2021
hYdos
approved these changes
Mar 19, 2021
proudmuslim-dev
approved these changes
May 14, 2021
MelanX
approved these changes
Dec 20, 2021
|
Closing and reopening to rerun checks. |
|
I have this issue on my singleplayer world, would love to get my nether and end dimensions avaliable again, how do I use this fix? I'm not good with code so this is probably really simple and im just dumb :D |
M4ximumPizza
approved these changes
May 10, 2023
|
Thank you for this PR! I believe the issue addressed here is now resolved by this commit. 😊 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really simple change that I believe fixes MC-197860. More details are in the issue there, but the root of the problem is the
UnboundedMapCodec's behavior in the case of erroring entries. Previously, this (along with any otherBaseMapCodecimplementor) would discard all valid entries after an error, while only actually reporting actual erroring entries.This PR moves the collection of read results outside the check for the data result in the accumulator, such that all valid entries will get added to the immutable map builder, while keeping intact the behavior of the
apply2stableon the actual success or failure of the result in question.