Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only accept numerical characters if the input type is number #112

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Only accept numerical characters if the input type is number #112

merged 3 commits into from
Mar 9, 2023

Conversation

vb
Copy link
Contributor

@vb vb commented Feb 17, 2023 •
edited
Loading

Issue

  • Input type number accepts e character as the initial character
  • If e is added to a string of numbers, the field is cleared
  • (Cannot understand why only e is accepted)

Solution

  • Block non-numerical characters if the input type is number

Fixes Mojang/minecraft-ui#4946

@vb vb requested review from pirelenito and ja-ni February 17, 2023 09:26
@vb vb merged commit f3d75a8 into main Mar 9, 2023
@vb vb deleted the core-ui/only-accept-numerical-input-for-type-number branch March 9, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirelenito pirelenito pirelenito approved these changes

@ja-ni ja-ni Awaiting requested review from ja-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vb @pirelenito