Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] tgui maintenance chores #239

Merged
merged 2 commits into from
Aug 16, 2021
Merged

[MIRROR] tgui maintenance chores #239

merged 2 commits into from
Aug 16, 2021

Commits on Aug 16, 2021

  1. tgui maintenance chores (#60859)

    ## About The Pull Request
    
    **Upgrades:**
    
    - Yarn 3.0
    - TypeScript 4.3
    - Sass 1.37
      - Required some refactoring of `/` into `math.div()` in CSS
    
    **Dependency removals:**
    
    - Removed ESM package, see: standard-things/esm#902
    
    I initially thought it was impossible to stop relying on this package, but fortunately, ES module support in Node 12+ now comes standard and I only had to convert the very few external module imports to `require()` (because Yarn PnP).
    
    I also moved `logging.js` directly into `tgui-dev-server` package, because that's where it is used. One less internal dependency.
    
    **Sidegrades:**
    
    - Removed creation of a common tgui chunk, because in practice it creates unnecessary complexity (devs sometimes get a white screen due to this chunk being invalid) and doesn't really save that much data on CDN, and **definitely** doesn't make tgui load faster.
    
    I think that is all. I tested it a bit and everything seemingly works.
    stylemistake authored and ms-mirror-bot committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    e9b8fd4 View commit details
    Browse the repository at this point in the history
  2. tgui maintenance chores

    ms-mirror-bot committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    51329f9 View commit details
    Browse the repository at this point in the history