New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msgpack Overhaul #354
Msgpack Overhaul #354
Conversation
This pull request introduces 5 alerts and fixes 1 when merging b2e4559 into c4e5245 - view on LGTM.com new alerts:
fixed alerts:
|
…trict no extras keywords in places
This pull request introduces 38 alerts and fixes 2 when merging 1f06ec8 into f3eea65 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 28 alerts and fixes 2 when merging da87985 into f3eea65 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 27 alerts and fixes 2 when merging c9f9c80 into f3eea65 - view on LGTM.com new alerts:
fixed alerts:
|
1 similar comment
Merging this in as it is blocking other PR's. @doaa-altarawy Please review in detail when you can. |
This pull request introduces 27 alerts and fixes 2 when merging 8718ddc into f3eea65 - view on LGTM.com new alerts:
fixed alerts:
|
Description
This PR accomplishes the following:
This will not pass CI until a number of other PR's and releases are in from Engine/Elemental. This does however pass locally (!), somewhat surprised by this.
Best part: Primary SQL msgpack overhaul was 27 lines of code. A clear win for OOP and adapters that we might want to use as an example. @sjayellis @doaa-altarawy
Status