add thread and ternary plots #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 7f5a94b into 7f5585d - view on LGTM.com new alerts:
|
|
Cool! This looks great. I agree that we need to hand code the ternaries from Plotly basics rather than their built in function. You may want to turn off the grid lines, like so.. |
dgasmith
reviewed
Oct 14, 2019
| @@ -229,3 +229,280 @@ def scatter_plot(traces: List[Dict[str, Any]], | |||
| figure = go.Figure(data=data, layout=layout) | |||
|
|
|||
| return _configure_return(figure, "qcportal-violin", return_figure) | |||
|
|
|||
|
|
|||
| def threads(data, labels, color=None, title='', xlimit=4.0, mae=None, mape=None, | |||
There was a problem hiding this comment.
We usually use mue/mure over mae/mape.
|
turn off the blue bkgd + white grid lines for both ternary and threads or just the former? |
|
For ternary for sure. For the threads you may want to consider shifting the chart +/- 0.5 to have the grid correctly line up, may with a view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DON'T MERGE as this is only rewrites of matplotlib routines that function on data. Presently no integration with QCA.
Todos
Questions
Status