Read version info from nf-core/demultiplex version file
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrulda
reviewed
Mar 8, 2024
matrulda
reviewed
Mar 8, 2024
This is to make it clear that these version come from e.g. the nf-core/demultiplex pipeline and not the seqreports pipeline.
|
Thanks for the review! Should be fixed now :) |
matrulda
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for runfolders processed with nf-core/demultiplex instead of arteria-bcl2fastq.
In the current version of snpseq_packs, the version of bcl2fastq is dumped to a file during processing. This won't be needed in the future since all nf-core pipelines collect all software versions in a single file.