MolochV2 event spec feedback WIP

[daodesigner]

WIP

• Write V2 Contract Events Spec for Ragekick, InternalTransfer, Deposit

• Review V2 Contract Events Spec (@ameensol )

• Actually emit new events

• Write Tests

• Tests Passing

V2 Contract Events

• event Ragekick(address indexed memberAddress, uint256 lootToBurn);
• event InternalTransfer(address indexed from, address indexed to, address indexed token, uint256 amount);
• event Deposit(address indexed memberAddress, address token, uint256 amount);

V2 Contract Events Tests

• event Ragekick(address indexed memberAddress, uint256 lootToBurn);
• event InternalTransfer(address indexed from, address indexed to, address indexed token, uint256 amount);
• event Deposit(address indexed memberAddress, address token, uint256 amount);

MolochV2 Events Spec Feedback

• The Ragequit event in _ragequit emits msg.sender — which is wrong for ragekicks. This needs to be memberAddress (as has been pointed out by @sbetamc earlier), or maybe we would even want a separate Ragekick event?
  Added the Ragekick event, will fixed the Ragequit param.

• In general, is the "outside world" fine with the getters and events we currently have? For example, internal transfers don't emit events at all.
  Added InternalTransfer and Deposit events for public visibility. (this adds significant overhead to some functions that fire multiple InternalTransfer events.

[pet3r-pan]

Ping @ameensol, close or merge?