Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design a 404 Page #110

Closed
4 tasks done
upupming opened this issue Jun 27, 2018 · 13 comments
Closed
4 tasks done

design a 404 Page #110

upupming opened this issue Jun 27, 2018 · 13 comments

Comments

@upupming
Copy link
Contributor

upupming commented Jun 27, 2018

I want to create a new issue

Melody Information

Melody Version: 1.5.6

Platform: ubuntu 18.04

Browser: Chrome

Expected behavior

404 page doesn't need comments, like below:

screenshot from 2018-06-27 18-57-34

Actual behavior

But now it has comments:

screenshot from 2018-06-27 18-42-13

The corresponding code is in /layout/page.pug:

else
    article#page
      h1= page.title
      .article-container!= page.content
    include includes/pagination.pug
    if page.comments !== false
      include includes/comments/index.pug

I originally intended to change else to else if page.type !== 'error' to disable comments on 404 page, but I think we can go further.

How about design a brilliant 404 error pages?

@Molunerfinn
Copy link
Owner

It's one of the v1.6 plans: https://github.com/Molunerfinn/hexo-theme-melody/projects/1

@upupming
Copy link
Contributor Author

By the way, it seems that the license image is down, doesn't it?

@Molunerfinn
Copy link
Owner

Nope...may be it's your network problem.
image

@upupming
Copy link
Contributor Author

upupming commented Jun 27, 2018

Sorry, it is my problem!

@Molunerfinn Molunerfinn added this to To do in v1.7 Plans Feb 5, 2019
@Molunerfinn Molunerfinn moved this from To do to In progress in v1.7 Plans Oct 9, 2019
@Molunerfinn
Copy link
Owner

image

Full Sreen Background Image 404 Page

@upupming
Copy link
Contributor Author

Cool, is this the final version or just an idea?

@Molunerfinn
Copy link
Owner

Final version & the text can be configured

@upupming
Copy link
Contributor Author

upupming commented Oct 14, 2019

It's very simple but prominent, and I'm totally in favor of this stylish design.
Will it be shipped in the next minor version of melody? I cannot wait! 😄

@Molunerfinn Molunerfinn moved this from In progress to Done in v1.7 Plans Oct 14, 2019
@Molunerfinn
Copy link
Owner

v1.7 is coming soon after I finished the docs

@Kiyo5hi
Copy link
Contributor

Kiyo5hi commented Oct 15, 2019

@Molunerfinn I know this might be stupid, but why my hexo is not generating the 404 page? I've already updated the theme and also updated my config file.

@Molunerfinn
Copy link
Owner

image
image
http://yoursite.com/404.html

@upupming
Copy link
Contributor Author

upupming commented Oct 15, 2019

@Kiyo5hi Did you forget to modify the 404.md file under the source folder?
Yeah, @Molunerfinn is right!
Finally, it is up and running on my website: https://upupming.site/404.html
image
For those want to copy the source/404.md:

---
title: 404
layout: 404
permalink: /404
---

@Kiyo5hi
Copy link
Contributor

Kiyo5hi commented Oct 15, 2019

@upupming @Molunerfinn Got it now. I've tried doing some similar stuff but did not know that I need to add permalink loll

Molunerfinn added a commit that referenced this issue Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.6 Plans
  
Awaiting triage
v1.7 Plans
  
Done
Development

No branches or pull requests

3 participants