Tests fail when mongomock is installed

[mgorny]

When mongomock is installed in the environment, flask-mongoengine fails three tests:

==================================================================== FAILURES =====================================================================
____________________________ test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Dict format as URI] _____________________________

app = <Flask 'tests.conftest'>, config_extension = {'MONGODB_SETTINGS': {'HOST': 'mongomock://localhost:27017/flask_mongoengine_test_db'}}

    @pytest.mark.parametrize(
        ("config_extension"),
        [
            {
                "MONGODB_SETTINGS": {
                    "HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"
                }
            },
            {
                "MONGODB_SETTINGS": {
                    "ALIAS": "simple_conn",
                    "HOST": "localhost",
                    "PORT": 27017,
                    "DB": "flask_mongoengine_test_db",
                    "IS_MOCK": True,
                }
            },
            {"MONGODB_HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"},
        ],
        ids=("Dict format as URI", "Dict format as Param", "Config variable format as URI"),
    )
    def test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings(
        app, config_extension
    ):
        """Make sure a simple connection pass ALIAS setting variable."""
        db = MongoEngine()
        app.config.update(config_extension)
    
        # Verify no extension for Mongoengine yet created for app
        assert app.extensions == {}
        assert current_mongoengine_instance() is None
    
        # Create db connection. Should return None.
    
        with pytest.raises(RuntimeError) as error:
>           assert db.init_app(app) is None
E           Failed: DID NOT RAISE <class 'RuntimeError'>

tests/test_connection.py:167: Failed
___________________________ test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Dict format as Param] ____________________________

app = <Flask 'tests.conftest'>
config_extension = {'MONGODB_SETTINGS': {'ALIAS': 'simple_conn', 'DB': 'flask_mongoengine_test_db', 'HOST': 'localhost', 'IS_MOCK': True, ...}}

    @pytest.mark.parametrize(
        ("config_extension"),
        [
            {
                "MONGODB_SETTINGS": {
                    "HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"
                }
            },
            {
                "MONGODB_SETTINGS": {
                    "ALIAS": "simple_conn",
                    "HOST": "localhost",
                    "PORT": 27017,
                    "DB": "flask_mongoengine_test_db",
                    "IS_MOCK": True,
                }
            },
            {"MONGODB_HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"},
        ],
        ids=("Dict format as URI", "Dict format as Param", "Config variable format as URI"),
    )
    def test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings(
        app, config_extension
    ):
        """Make sure a simple connection pass ALIAS setting variable."""
        db = MongoEngine()
        app.config.update(config_extension)
    
        # Verify no extension for Mongoengine yet created for app
        assert app.extensions == {}
        assert current_mongoengine_instance() is None
    
        # Create db connection. Should return None.
    
        with pytest.raises(RuntimeError) as error:
>           assert db.init_app(app) is None
E           Failed: DID NOT RAISE <class 'RuntimeError'>

tests/test_connection.py:167: Failed
_______________________ test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Config variable format as URI] _______________________

app = <Flask 'tests.conftest'>, config_extension = {'MONGODB_HOST': 'mongomock://localhost:27017/flask_mongoengine_test_db'}

    @pytest.mark.parametrize(
        ("config_extension"),
        [
            {
                "MONGODB_SETTINGS": {
                    "HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"
                }
            },
            {
                "MONGODB_SETTINGS": {
                    "ALIAS": "simple_conn",
                    "HOST": "localhost",
                    "PORT": 27017,
                    "DB": "flask_mongoengine_test_db",
                    "IS_MOCK": True,
                }
            },
            {"MONGODB_HOST": "mongomock://localhost:27017/flask_mongoengine_test_db"},
        ],
        ids=("Dict format as URI", "Dict format as Param", "Config variable format as URI"),
    )
    def test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings(
        app, config_extension
    ):
        """Make sure a simple connection pass ALIAS setting variable."""
        db = MongoEngine()
        app.config.update(config_extension)
    
        # Verify no extension for Mongoengine yet created for app
        assert app.extensions == {}
        assert current_mongoengine_instance() is None
    
        # Create db connection. Should return None.
    
        with pytest.raises(RuntimeError) as error:
>           assert db.init_app(app) is None
E           Failed: DID NOT RAISE <class 'RuntimeError'>

tests/test_connection.py:167: Failed
================================================================ warnings summary =================================================================
.tox/py36/lib64/python3.6/site-packages/_pytest/config/__init__.py:1230
  /tmp/flask-mongoengine/.tox/py36/lib64/python3.6/site-packages/_pytest/config/__init__.py:1230: PytestConfigWarning: Unknown config option: env_override_existing_values
  
    self._warn_or_fail_if_strict("Unknown config option: {}\n".format(key))

-- Docs: https://docs.pytest.org/en/stable/warnings.html
============================================================= short test summary info =============================================================
FAILED tests/test_connection.py::test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Dict format as URI] - Failed: DID NOT RAIS...
FAILED tests/test_connection.py::test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Dict format as Param] - Failed: DID NOT RA...
FAILED tests/test_connection.py::test_connection__should_parse_mongo_mock_uri__as_uri_and_as_settings[Config variable format as URI] - Failed: D...
===================================================== 3 failed, 42 passed, 1 warning in 4.16s =====================================================

[insspb]

@mgorny Please specify flask-mongoengine version. New version just deployed to pip several hours ago, please test it.

[mgorny]

Reproduced with 0.9.5, 1.0.0 and git master (e090909).

You should be able to reproduce it easily by adding mongomock to tox env:

diff --git a/tox.ini b/tox.ini
index 7216f15..0569904 100644
--- a/tox.ini
+++ b/tox.ini
@@ -6,6 +6,7 @@ commands =
     python -m pytest {posargs}
 deps =
     PyMongo>3.9.0
+    mongomock
     pytest
     pytest-cov
 

[insspb]

@mgorny Please take a look at #429, I think changes from there will help.

[mgorny]

I've applied the changes from #429, and the tests still fail, with the same message.

[insspb]

@mgorny thanks for info. I will try to find some time to look at mongomock, but no schedule promises

[insspb]

@mgorny ok, since almost 2 years from issue I have some time to back to this project.
This issue now for sure fixed in my PR related to connection module and will be soon in master....

[insspb]

@mgorny I made a special mark for mongomock related tests, as mentioned 3 tests had assertion that mongomock is not installed. So we will just skip them in systems, where mongomock installed. As our CI/CD work with real mongo, as well as our new nox configuration.