Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a time to look at connection module, that originally was made in 2016-2017. In nearest past there was a lot of question and bugs related to connection.
By my opinion our old connection module did a lot of work, that should not be done in this package at all.
For example there is some things that by my opinion is not correct:
So at the end this Pull request will:
User is now fully responsible to set correct defaults, or defaults from upstream mongoengine and pymongo will be used.
MongoEngine
class now will always return dict with one or many database connections.TODO before merge:
Should fix:
I honestly hope for any comments, and for some test users, as it is deep flask-mongoengine behavior change. Code reviews are welcomed on any stage.