Add max_length feature to StringField-like fields #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,20 +6,24 @@ | |||
| import sys | |||
|
|
|||
| from wtforms import widgets | |||
| from wtforms.fields import SelectFieldBase, TextAreaField, StringField | |||
| from wtforms import fields as f | |||
There was a problem hiding this comment.
Why?
It is nothing of consequence to import directly everything you want. It won't impact potential cycle imports because of how you are using these fields.
What is much worse is the one-letter variable.
|
IMHO, this looks much hackier than it should. There has to be a better way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about such a feature?
The idea is to pass max_length to the call to the field so that max_length appears in the input field in the HTML code.
Client pre-validation is nice. I'd like to go even further with #214.