fix app out of context when create connection #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ntcong. Connection is being reworked by @losintikfos (#98, #71 (comment)). @losintikfos, any advice on this? Any progress on the connection rework? |
|
@lafrech I have been pretty busy on other projects. I will test the connection re-work towards mid week to enable us progress on our release plan. |
|
OK, thanks. I didn't mean to rush you. |
|
I forgot about this PR before commenting in #220. As I said there, if the test about the TESTING config parameter is actually needed, I'd rather pass |
|
I guess we can close this PR now that #220 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposed fix for #220. Because there's no application context yet, current_app will fail.
Flask's extension guideline tells us to use application context only when we passed it, so we should pass the TESTING condition to _create_connection.