Fixes #458, DecimalField now ignores incorrect values until validate is called just like FloatField #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l validate is called, just like FloatField.
rozza
added a commit
that referenced
this pull request
Sep 27, 2013
Fixes #458, DecimalField now ignores incorrect values until validate is called just like FloatField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in issue #458, while creating a document with kwargs, incorrect values for FloatFields are ignored until
doc.validate()is called, but the same was not the case with DecimalFields, where adecimal.InvalidOperationexception is raised immediately.This commit fixes that and brings the 2 fields closer. Although I'm not sure if this is the desired direction of MongoEngine.