-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized Dockstat Flow #5957
Conversation
mas_farewells.dockstat_cancel_dlg_label = None | ||
mas_farewells.dockstat_wait_menu_label = None | ||
mas_farewells.dockstat_cancelled_still_going_ask_label = None | ||
mas_farewells.dockstat_failed_io_still_going_ask_label = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a function version of setting all of these to None, in case a non-generic label needs to do this for some reason?
Co-authored-by: Totally a booplicate <53382877+Booplicate@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the marisa CG lines being commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind this
1729020
Co-authored-by: Totally a booplicate <53382877+Booplicate@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time I did it right
fd937c0
Adjusted the dockstat flow such that it's completely modular. Simply passing in a label for a specific part will replace that part of the generic flow with the one provided (should the label exist)
Added:
6 new variables to control the dockstat flow
dockstat_iowait_label
:dockstat_rtg_label
:dockstat_cancel_dlg_label
:dockstat_wait_menu_label
:dockstat_cancelled_still_going_ask_label
:dockstat_failed_io_still_going_ask_label
:If these are None or non-existent labels, the generic is used (generic being the current standard flow for the taking you somewhere farewell)
Testing:
NOTE: This also comments out some CG code in Marisa/Rin o31 greets