Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom key shortcuts #118

Closed
Volodymyr-13 opened this issue Aug 28, 2019 · 20 comments
Closed

Support for custom key shortcuts #118

Volodymyr-13 opened this issue Aug 28, 2019 · 20 comments
Assignees
Labels
Status: Done Work on this issue is complete. Will be available on next release Type: Feature Request Issue is a new feature proposal
Projects
Milestone

Comments

@Volodymyr-13
Copy link

Volodymyr-13 commented Aug 28, 2019

I have a macmini and a simple keyboard. How to control brightness via keys?
Just want to assign custom Key's for some action. For example, F1-F2 for brightness.

Perhaps, basically something like:

Screen Shot

edit: in my app it was dumb simple)
https://github.com/KAMIKAZEUA/NativeDisplayBrightness

Screen Shot 1

@JoniVR JoniVR added Priority: Minor Issue is minor (e.g. Monitor or cable type specific…) Type: Enhancement Issue is an app enhancement labels Aug 28, 2019
@JoniVR
Copy link
Member

JoniVR commented Aug 28, 2019

Always welcome to make a PR if you want to! :)

@Volodymyr-13
Copy link
Author

Volodymyr-13 commented Aug 28, 2019

I don't know swift at all and I don't like it :), but honestly, the main problem - I don’t have time to support my program or any other. Just found this app and it's looks almost perfect, except keys and also smooth brightness change :) like just by +-1%

@JoniVR
Copy link
Member

JoniVR commented Aug 28, 2019

Smooth brightness/volume should work like it does natively on a mac using shift + alt modifiers :)

@Volodymyr-13
Copy link
Author

Okay, I see. But just for constant and precise control I've set smooth option enabled by default. Never used Apple keyboard's..

@Volodymyr-13
Copy link
Author

@JoniVR Any news :) ?

@Bogey
Copy link

Bogey commented Jan 15, 2020

I can tell that KAMIKAZEUA's NativeDisplayBrightness works on my rig.
Though I have to disable Display Keyboard shortcuts in System Preferences and set them in NativeDisplayBrightness.

Setting brightness with MonitorControl only works with the slider.
With the keys I can only control the sound, though I would like to remap these keys because the keys overtake the default MacOS sound output. My speakers are connected to the computer and not the monitor. The monitor has headphones that I use at night.

Perhaps the keys are working, but my keyboard cannot pass them on ... if MonitorControl is listening for F14/F15 -- because I don't have those keys.

Keyboard I'm using is Logitech K780 and monitor is LG 25UM58-G

@Bogey
Copy link

Bogey commented Jan 16, 2020

This is the one I'm currently using:
https://github.com/fnesveda/ExternalDisplayBrightness

@JoniVR
Copy link
Member

JoniVR commented Jan 22, 2020

Just an fyi, I am working on this but it requires quite a big rewrite and I don't have that much free time right now.. so it might take me some time.

@Volodymyr-13
Copy link
Author

@JoniVR Hey, is this implemented?

@JoniVR
Copy link
Member

JoniVR commented Apr 4, 2020

Not yet, I decided that I would be too many changes at once, I do plan on implementing it in the future though. Sorry if you were waiting for it.

@CharlesCCC
Copy link

Looking forward to this feature, because I noticed I can only adjust brightness with the Apple Magic Keyboard, non other keyboard(PC keyboard) can be used to adjust the brightness. which is the only thing that I miss about this App, everything else was perfect. (it all worked quite well with my LG 34 UltraWide along with two 4k AOC monitors). Love it, thank you for the great work.

@sovon
Copy link

sovon commented Aug 2, 2020

Hi, I'm a long time user of this utility. My 3rd wired Apple Magic Keyboard died and I have bought this Logi K380 keyboard recently.

If I map F6 and F7 from System Preferences>Keyboards>Shortcuts>Display I can control the brightness of my laptop's built in display(with Fn+F6) but it doesn't affect the external monitor. I could easily use Logitech Options but I don't want to use a separate tool just for this one single feature.

Can you please add a feature so that MonitorControl listens to the Fn+KEY commands or maybe add a custom key binding feature, whichever is simpler?

Screenshot 2020-08-02 at 8 29 36 PM

Screenshot 2020-08-02 at 8 23 53 PM

@CharlesCCC
Copy link

Note: Today I just noticed my keyboard (microsoft sculpt ergonomic keyboard) works perfect for the default brightness control;
the ScrLk is F14, Pause is F15, which corresponding to brightness change for Mac. (It works perfect in my MBP and my Hackintosh) and it works regardless if the keyboard is in the Function model or not.

@ryangrahamnc
Copy link

I was able to get this working by installing Karabiner-Elements.
brew cask install karabiner-elements
Its default settings set f1/f2 for brightness and f10/f11/f12 for volume, which you can alter in the "function keys" tab.
(It sets up a new keyboard device, so you might need to update its keyboard to use the right meta keys in system prefs->keyboard->modifier keys)

@adrien3d
Copy link

@JoniVR any updates on this feature ? Thank you very much for your work so far ;)

@JoniVR
Copy link
Member

JoniVR commented Sep 19, 2020

I unfortunately don't have a lot of time lately, I'm trying to push through as many stability improvements as I can when I get the time but unfortunately the way MonitorControl is currently written, supporting custom shortcuts isn't really that easy to implement, it's a big feature that needs proper time and care. If anyone else feels up for the task I'd be more than happy to accept PRs for it though.

@waydabber
Copy link
Member

There are some custom shortcut requests and these are legit I think, MC should be adding this as an option. As I checked out MediaTapKeys' code it could be added easily. Also there are other solutions as well out there which could be integrated if needed.

@waydabber waydabber removed the Type: Enhancement Issue is an app enhancement label Aug 21, 2021
@waydabber waydabber removed the Priority: Minor Issue is minor (e.g. Monitor or cable type specific…) label Sep 4, 2021
@waydabber waydabber removed their assignment Sep 4, 2021
@waydabber waydabber assigned waydabber and unassigned JoniVR Sep 28, 2021
@waydabber waydabber added the Status: In progress Issue currently being worked on label Sep 28, 2021
@waydabber waydabber added this to In progress in v4.0.0 Sep 28, 2021
@waydabber
Copy link
Member

waydabber commented Sep 28, 2021

Something like this will suffice I hope:

Screen Shot 2021-09-28 at 20 52 36

Thing is getting a bit more complicated than I thought as I'll have to simulate keyboard repeat which is not happening with shortcuts.

@aik099
Copy link

aik099 commented Sep 28, 2021

Something like this will suffice I hope:

Screen Shot 2021-09-28 at 20 52 36

Thing is getting a bit more complicated than I thought as I'll have to simulate keyboard repeat which is not happening with shortcuts.

Sure, @waydabber .

@waydabber
Copy link
Member

This is now working nicely as far as I was able to test. Also added keyboard repeat support.

@waydabber waydabber added Status: Done Work on this issue is complete. Will be available on next release and removed Status: In progress Issue currently being worked on labels Sep 28, 2021
@waydabber waydabber moved this from In progress to Done in v4.0.0 Sep 28, 2021
@waydabber waydabber added this to the 4.0.0 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Work on this issue is complete. Will be available on next release Type: Feature Request Issue is a new feature proposal
Projects
Development

No branches or pull requests

9 participants