Add a setting to control the function of F14 / F15 keys

[vtns]

Hi
The request contains the change which add a preference / checkbox to control whether if F14 / 15 key acts as brightness control or not.

The request also contains minor fix to Japanese localized text.
Feel free to drop this since there are still many unlocalized text anyway.

[waydabber]

Hi @koyama-tadayoshi, thanks for the contribution! The solution looks solid. The only issue I have that a lot of things were rewritten in 3.1.0 and even though I can commit this into master, it won't be compatible with the new code and merging would be tedious.

The setting could go to the Keyboard tab of 3.1.0 but probably there will be a new Shortcuts tab, where the keyboard shortcuts (including custom shortcuts which is an old request) will be managed in general.

Note that this screenshot is the advanced view, the normal view is much simpler:

The setting about F14/F15 would obviously be classified as an advanced option.

[vtns]

Wow
3.1.0 looks cooler. I'm looking forward to it.

including custom shortcuts which is an old request
When you provide the way to customize shortcut, there may be no need for this option (about F14 / F15).
since we can have MediaKeyTap.useAlternateBrightnessKeys always be set to false
and the user who want to control brightness with F14 / F15 still be able to do it using customize key feature.

Anyway Thanks lot for bringing the great tool.
I'm using your application everyday.

[waydabber]

Hi @vnts, I'll leave this here for now and marked it with Conflicts. I'll use your code to add the F14/F15 thing to 3.1.0 if it is ok with you.

@JoniVR - alternatively we might add this to 3.0.0 and maybe release this and the recent translations as 3.1.0 and the version I am working on in the current 3.1.0 branch could be reclassified to 4.0.0 as it is shaping to be a rather big release with probably even more things in it than 2.1.0->3.0.0. It will take time to properly finish and test it, also it will need some betas as well. What do you think?

[vtns]

I'll use your code to add the F14/F15 thing to 3.1.0 if it is ok with you.

Of course, it's ok. Sorry for my misunderstanding.

[waydabber]

Hi @JoniVR, @the0neyouseek - what should be the way forward regarding this? I renamed the existing 3.1.0 branch to 4.0.0 as it is still in development. If you agree with the change made by @vtns then we could merge this to the master and release s 3.1.0 with this and the updated translations that were added during the past two weeks. What do you say?

[JoniVR]

@waydabber Sounds good to me, Do we want to go ahead and release v3.1.0 in combination with 4.0.0 beta or do we wait with v4.0.0 betas for a bit?

[JoniVR]

One thing we should note with this change is that the default behaviour changes from these keys being enabled to being disabled, so we might get some issues regarding this.

We could either default the toggle to enabled or just leave it as is and deal with the issues. Though I doubt many people will notice.

[JoniVR]

Related to #100

[waydabber]

@waydabber Sounds good to me, Do we want to go ahead and release v3.1.0 in combination with 4.0.0 beta or do we wait with v4.0.0 betas for a bit?

I am still working on it and also I did not test it properly so it might not be entirely stable yet. Now I am trying to do something different than last time - I'll implement whatever should be implemented and then use the betas to actually aim for stability instead of having a moving target. :)

[waydabber]

One thing we should note with this change is that the default behaviour changes from these keys being enabled to being disabled, so we might get some issues regarding this.

We could either default the toggle to enabled or just leave it as is and deal with the issues. Though I doubt many people will notice.

Hmm you are right. It would have been better to add this as a false-default option that does not upset existing behavior (it could have been named disableAltBrightnessKeys or something as having the alternative keys working is the normal state of the app).

[JoniVR]

Alright, let me know whenever you feel like we're ready for beta, my recent weeks have been pretty busy, as will this week be, but I'll make time for some releases when necessary. I was also still working on the slider but that's going pretty slowly..

[JoniVR]

About the default, I honestly don't think it matters that much, 97% of users probably don't even have a keyboard with f14/15 keys, and the other 3% probably doesn't even know/care about it doubling as brightness keys.

[waydabber]

Probably you are right. I don't know how many PC/generic keyboard users there are. I wasn't avare that F14/F15 maps to ScrLK and Pause until I tried to use MonitorControl on the Hackintosh I had to install to debug the Intel stuff and I stumbled upon it by accident even then.

[JoniVR]

Yeah, I had added the option in MediaKeyTap a while back but didn't get to implementing it in MonitorControl yet. It has been a long standing issue.