Prettify Adminwho into an examine block, display non-admin admins separately #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Same vein of tgstation#71170 (2d3e7f2) / tgstation#69845 (61d49cb) in an attempt to lessen the number of cruddy "system messages" that just print straight text to chat. This could be improved CSS wise but I think a standard examine block helps a lot while maintaing clarity, see below:  I also heavily refactored adminwho code to not have so much copypasta while using more `jointext()` and keeping everything a bit more readable than what it previously was. User-facing stuff should all be the same (with the addition of an examine block) except in two spots * Custom header message when no admins are online. I think this is a far clearer message than having `Current Admins:` and then the message about adminhelps being relayed to Discord * There's no tabs per each entry. This was replaced by a bullet point. I think it's better to read. ## Why It's Good For The Game As time goes on, I'm more and more peeved by these pretty critical messages constantly blending in with output from the rest of the game. This is why balloon_alerts and whatever became so popular to my eyes, there's just constant junk. I figure that we may as well just keep the systematic stuff that _must_ live in the chat box looking as neat as possible. ## Changelog :cl: qol: Adminwho messages are now in an examine block for heightened clarity. /:cl:
|
would be neat if we also added mentors into that adminwho block, and just turned it into staff-who |
This was referenced Mar 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation#79137 and BeeStation/BeeStation-Hornet#9321
Testing Evidence
Changelog
🆑 Absolucy, san7890, EvilDragonfiend
qol: Who and Adminwho messages are now in an examine block for heightened clarity.
admin: Admins without R_ADMIN perm are sorted in another section in staff_who, so that people will not believe coders can handle adminhelps.
/:cl: