[Port] Chemmaster refactor #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion#75849)  Chem master has been using some hard coded styles for containers, pills and patches. Some people didn't bother to update styles, and they stayed outdated. Now it uses just a list of reagent containers instead, which makes it easy to add new containers - just one line of code. Also changed its sprite for better animations, emissive overlay, and to display buffer reagents on the sprite itself. Now it plays printing animation when you actually print containers and servos have a purpose now - they increase the amount of containers printed at once by up to 100% * part_tier. Pills and patches are always printed at double amount. And fixes tgstation#59734 Makes chem master easier to manage in code and easier to use in-game. Printing delay is added for consistency with other fabrication machines (like lathes), to give a purpose for the servo motor used in construction, for visuals (to show the printing animation only when something is being printed, and not just when you move stuff in and out of buffer as before) and to prevent people from spamming the world with unneeded objects with 0 second delay. :cl: qol: Chemmaster UI tweaked fix: Fixed chem master showing wrong data during reagent analysis fix: Fixed chem master not working with fermented drinks image: Chemmaster resprited, now has an indicator for buffer reagents refactor: Refactored chemmaster code, it now uses reagent containers instead of styles balance: Chemmaster now uses servos and has printing animation of 0.75 second duration. Outputs 1 container or up to 2 pills/patches per cycle by default. Can be upgraded to output up to 4 and 8 with t4 servos. /:cl:
 Resprited many condiment containers. And a tray (don't know why, it just was in the dmi) Replaced the old condiment bottle from Condi Master with the one that was used in Chem Master before the test tubes. More in line with other 3/4 stuff :cl: image: Resprited many condiment containers image: Added a sprite for cooking oil / corn oil container image: Replaced old condiment bottles with the newer bottles in Condi Master /:cl:
 Bottles have varied volumes - some of them hold 30, some 50, while having the same sprite. And the size is comparable with small beaker, so it was a bit weird that it can hold only 30 units. Now the default bottle volume is 50, consistently. Test tubes are the new 30u container that replaces bottles created in chem master (but not condi master) and pandemic. For better management of test tubes, this PR also adds a rack that can be crafted from 1 wooden plank. The rack stores up to 10 test tubes and can pick them up and drop quickly similar to how the pill bottle works with pills.  Consistent volume for the bottle sprite instead of some being 30, some 50. Essential attribute for chemical lab, good company for Chem Separator. :cl: MTandi, coiledlamb add: Added test tubes and racks for them balance: All 30u bottles now have 50u volume and chem master/pandemic spawn tubes instead of bottles /:cl:
This was referenced Jun 21, 2024
Open
|
currently broken as in can't set the amount of items |
This was referenced Jun 22, 2024
Closed
Closed
Open
This was referenced Jun 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports:
Chemmaster:
Remote Factory Output:
Chemical Press:
Why It's Good For The Game
More sprites for patches and pills
Changelog
🆑
qol: Chemmaster UI tweaked
qol: Chemical Press UI tweaked
fix: Fixed chem master showing wrong data during reagent analysis
fix: Fixed chem master not working with fermented drinks
image: Chemmaster resprited, now has an indicator for buffer reagents
refactor: Refactored chemmaster code, it now uses reagent containers instead of styles
balance: Chemmaster has printing animation of 0.75 second duration. Outputs 1 container or up to 2 pills/patches per cycle by default. Can be upgraded to output up to 4 and 8 with t4 manipulators.
image: Resprited many condiment containers
image: Added a sprite for cooking oil / corn oil container
image: Replaced old condiment bottles with the newer bottles in Condi Master
add: Added test tubes and racks for them
balance: All 30u bottles now have 50u volume and chem master/factory output/chemical press/pandemic spawn tubes instead of bottles
/:cl: