Take advantage of how thing.get_all_contents() already includes src as part of the contents list

[LikeLakers2]

About The Pull Request

Certain objects in SS13 make checks on both an atom and that atom's contents. For example, /obj/effect/gun_check_blocker/CanPass() checks the atom and all of the atom's contents, preventing the atom from moving through it if any of them are of type /obj/item/gun.

However, when doing this, the code assumes that thing.get_all_contents() does not include thing - and so, performs the check twice - once on thing, and once on every object in thing.get_all_contents().

Yet, /atom/proc/get_all_contents() already includes src as part of the list. In fact, it even initializes the list with src in it:

Monkestation2.0/code/__HELPERS/atoms.dm

Lines 4 to 12 in 72a3063

	///Returns the src and all recursive contents as a list.
	/atom/proc/get_all_contents(ignore_flag_1)
	. = list(src)
	var/i = 0
	while(i < length(.))
	var/atom/checked_atom = .[++i]
	if(checked_atom.flags_1 & ignore_flag_1)
	continue
	. += checked_atom.contents

This PR takes advantage of this fact, removing the redundant check on thing, as thing will just be checked again within the for loop over thing.get_all_contents().

Why It's Good For The Game

Removes redundant code, resulting in a little less CPU time used checking an atom and all its contents.

Changelog

N/A - this does not include any changes that players would notice.

[Zonespace27]

Lgtm mostly

[DexeeXI]

If Zone says a particular change is pretty good, then it should be pretty good to do.