Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Removes per z level station relays, allows tcomms to reach across interconnected zs #2038

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

Absolucy
Copy link

Port of tgstation#76360, from #1810.

The second layer of tram does not need its own relay, it is like 10 feet max above the first.
Feels wrong in game, mappers tend to just sneak these off in corners, it sucks.
Shouldn't need to do it.

Instead, tcomms z levels will be filled based off the z stack, rather then just the layer itself.

Adds a list/helper to make this more efficient/more easily duplicable

Matches what people expect better, removes redundant map bits, better vibes.

🆑 Absolucy, LemonInTheDark
balance: Tcomms now works across connected (vertically) zlevels. No more hunting in maint for the relay.
/:cl:

…erconnected zs (tgstation#76360)

The second layer of tram does not need its own relay, it is like 10 feet
max above the first.
Feels wrong in game, mappers tend to just sneak these off in corners, it
sucks.
Shouldn't need to do it.

Instead, tcomms z levels will be filled based off the z stack, rather
then just the layer itself.

Adds a list/helper to make this more efficient/more easily duplicable

Matches what people expect better, removes redundant map bits, better
vibes.

:cl:
balance: Tcomms now works across connected (vertically) zlevels. No more
hunting in maint for the relay.
/:cl:
@dwasint dwasint merged commit 4a26e47 into Monkestation:master Jun 21, 2024
17 of 18 checks passed
github-actions bot added a commit that referenced this pull request Jun 21, 2024
@Absolucy Absolucy deleted the peecomms branch June 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants