Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buncha misc qol stuff and tg ports #1810

Closed
wants to merge 69 commits into from

Conversation

Absolucy
Copy link

@Absolucy Absolucy commented May 2, 2024

Ports:

Changelog

🆑
balance: The DNA vault now requires WAY less plant dna - anywhere from 8 to 15 samples.
fix: Fixed some various runtime errors.
del: Disabled the Syndicate Shocktroops event from occurring naturally.
qol: The curator's radio now ignores exospheric anomalies and signal jammers.
qol: Having the alcohol tolerance quirk now (just BARELY) prevents alcohol from completely killing your liver.
fix: Nukie Mediborgs no longer kill slimes with their nanites.
balance: Reinforced sections of station hull have gotten better at mitigating explosive shockwaves.
add: Anomalies, portals, and bluespace rifts will now wibble a bit.
image: Resprited the t-ray scanner, gas analyzer, geiger counter and hand drill.
add: When you are drunk, the strength of your slurring now varies based on how drunk you are. Being "a little drunk" only rarely slurs your words, being average drunk is the same as the old effect, while being very drunk now slurs your words even more.
add: Some non-alcohol sources of slurring, such as concussions, now give "generic slurring" rather than "drunk slurring", which less resemble being drunk (ie, no burping).
add: Engineers now have an RCD round start.
balance: RCD construction/deconstruction effects can now be attacked in order to cancel them. You can get the anti-disruption upgrade disk to prevent this.
balance: RCD construction/deconstruction is now slower if you already have another effect up. This does not effect reconstruction.
balance: Both of the above effects do not effect the CE's roundstart RCD, nor any other RCDs such as combat RCDs.
add: RCDs can make girders now.
fix: Some RCD constructs took more material than manual construction. The RCD cost should be consistent in comparison to manual construction now.
fix: RCDs can build wallmounts on reinforced walls.
qol: RCDs can build directional windows without requiring/building a grill.
fix: You should be able to click on lattices on icebox with the RCD and construct a floor now
balance: Maintenance drones now can use RPED, RCD, holosigns, and spray bottles.
balance: Tcomms now works across connected (vertically) zlevels. No more hunting in maint for the relay.
qol: Add high-traction floor tiles to medbay/engi/sci showers.
fix: Fixed various sprites like gloves looking weird and bad with taller heights.
fix: Tokening for wizard now removes you from the crew manifest (as wizards usually aren't on the manifest).
fix: The shuttle will no longer delete you while you are in jaunt.
image: medical and improvised gauze are visibly different from cloth.
fix: Supermatter shards now have screentips with a wrench in hand.
fix: Aheals now properly heal ear deafness.
fix: Now falsewalls visually don't close when they shouldn't.
qol: Increased threshold of trace n2o required to make euphoria and giggles happen.
image: New liquid plasma sprites from SS14!
balance: You can no longer visually track something (See: AI tracking) if that object is inside something. You are also considered invisible by tracking if your alpha level is less than 50.
add: Cigarette smoke is now more smokey.
add: Taking a cigarette out of your mouth will let out a big puff of smoke.
image: Updated the sprites of the advanced surgical tools, so it's easier to see which mode they're set to at a glance.
fix: Hats/glasses/masks should hopefully behave more predictably for the purposes of eye/mouth surgery.
fix: You will now be ejected from Space Phase if you lose your focus or lose consciousness somehow during the jaunt.
spellcheck: adjusted font size from 30px to 15px.
qol: Arrivals shuttle is now more player friendly.
qol: Uninverted the inverted corner of the IceBox medbay treatment center.
qol: Basic spider eggs no longer flash the byond window when ready to hatch.
qol: Toy hot potatoes no longer give a ghost notification.
qol: Deadchat will be notified in the event of an imminent macrobomb detonation, HFR meltdown, organ harvesting,
qol: Deadchat will be notified when a nuclear/doomsday device is activated, as well as when a blob-infection bursts.
qol: Suit sensors can now be maxed by ctrl clicking your jumpsuit.
qol: Various jobs have gotten additional programs uploaded at roundstart, engineers now have the canary and atmospheric scanner programs, atmospheric technicians now have the supermatter monitor, and Robotisists/RDs now have the silliconnect program.
qol: You can now open airlocks (That you have access to) while inside a stealth implant box.
qol: Wizard Spellbook is now alphabetized.
qol: Wizard Spellbook now has a search bar!
qol: The notepad app now includes basic nautical directions in its default message.
qol: A tip about nautical directions, too.
qol: Telecomms is quieter and less ear-damaging..
sound: Modified tcomms sound to remove high-tones.
fix: The telecomms sound only comes from the server hub machine.
qol: Assistants with <10h of playtime are now "Interns".
qol: Ghosts will now get a notification when someone is about to be hit by the tram.
add: Ponies.
balance: Supermatter zap power generation scales with the delta time between its last zaps, preventing faster zapping from scaling power generation to extreme levels.
fix: Fixes supermatter zap rate not scaling properly. It should zap much faster at higher energy levels as intended.
qol: Changeling chemical generation scales with the world's delta time, making its rate independent of subsystem lag.
qol: Revenant essence generation scales with the world's delta time, making its rate independent of subsystem lag.
qol: Xenomorph plasma generation and resin healing scales with the world's delta time, making their rates independent of subsystem lag.
qol: The "Explosive Planted" alert for C4 actually shows the C4.
qol: Instrument delivery beacons now fit in pockets.
qol: Supermatter shards can now be fastened with right click too. Now, just don't forget to use a wrench.
qol: ID cards tooltips now show how to assign a new account.
qol: Rats no longer spawn on multiz cable hubs.
fix: Fixed a bug that would cause you to be unable to lean again if you tried leaning while facing the wrong direction.
qol: Shuttles will no longer show their current destination as a choice while in transit.
qol: Make notepad available for everyone, who has only laptop or console.
/:cl:

@Absolucy
Copy link
Author

Absolucy commented May 5, 2024

This can prolly be merged via rebase or merge rather than squash, as the commits are all either atomic (did exactly what it says on the tin) or cherry-picks - would make reverting individual parts of it in the future far easier if needed

@Absolucy
Copy link
Author

Absolucy commented May 12, 2024

ignore ci failure, it's the unrelated, rng mythril runtime:

/datum/unit_test/create_and_destroy
  [23:51:55] Runtime in code/__HELPERS/stack_trace.dm,4: item_pickup overridden. Use override = TRUE to suppress this warning.
  Target: the mythril (/obj/item/stack/sheet/mineral/mythril) Proc: on_pickup (code/datums/signals.dm:39)
    proc name:  stack trace (/proc/_stack_trace)
    src: null
    call stack:
     stack trace("item_pickup overridden. Use ov...", "code/datums/signals.dm", 39)
    /datum/element/curse_announcem... (/datum/element/curse_announcement): RegisterSignal(the mythril (/obj/item/stack/sheet/mineral/mythril), "item_pickup", "on_pickup", 0)
    /datum/element/curse_announcem... (/datum/element/curse_announcement): Attach(the mythril (/obj/item/stack/sheet/mineral/mythril), "The mythril is cursed with the...", "#8a0c0ca1", "", /datum/component/fantasy (/datum/component/fantasy))
    the mythril (/obj/item/stack/sheet/mineral/mythril):  AddElement(/list (/list))
    curse of hunger (/datum/fantasy_affix/curse_of_hunger): apply(/datum/component/fantasy (/datum/component/fantasy), "mythril")
    /datum/component/fantasy (/datum/component/fantasy): modify()
    /datum/component/fantasy (/datum/component/fantasy): InheritComponent(null, 1, null, null, null, null)
    the mythril (/obj/item/stack/sheet/mineral/mythril):  AddComponent(/list (/list), null)
    Magical (/datum/material_trait/magical): on trait add(the mythril (/obj/item/stack/sheet/mineral/mythril))
    the mythril (/obj/item/stack/sheet/mineral/mythril): create stats from material(/datum/material/mythril (/datum/material/mythril), 0)
    the mythril (/obj/item/stack/sheet/mineral/mythril): Initialize(0, null, 1, null, 1)
    the mythril (/obj/item/stack/sheet/mineral/mythril): Initialize(0, null, 1, null, 1)
    Atoms (/datum/controller/subsystem/atoms): InitAtom(the mythril (/obj/item/stack/sheet/mineral/mythril), 0, /list (/list))
    the mythril (/obj/item/stack/sheet/mineral/mythril): New(0)
    /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
    RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
    RunUnitTests()
    /datum/callback (/datum/callback): InvokeAsync()

Shadow-Quill and others added 6 commits May 20, 2024 02:53
…tion list (tgstation#75170)

## About The Pull Request

Shuttles with multiple destinations will no longer show the current
destination as a selectable choice during transit.

<details>
<summary>Example</summary>
A shuttle has two possible destinations. A and B. <br>
While at A, the only valid destination is B and vice-versa. <br>
But while in transit to B, _both_ A and B can be chosen as destinations.
<br><br>
The change now hides B as a valid destination, as you are already going
there. <br>
It has the nice side effect of making shuttles with only two
destinations never showing a dropdown list while in transit.
</details>

## Why It's Good For The Game

Telling the shuttle to go to the same place as you're going to doesn't
do anything.

## Changelog
:cl:
qol: Shuttles will no longer show their current destination as a choice
while in transit.
/:cl:
## About The Pull Request

Another to add to tgstation#75140 The
bad luck omen has an event where you're electrocuted and guaranteed to
be hit by the tram. This lets them get a few seconds notice.


![image](https://user-images.githubusercontent.com/83487515/236582851-cdf55726-0990-4811-bb37-124aac4c59d2.png)


## Why It's Good For The Game

Watch them go flying, hit a vending machine, and the vending machine
falls on them gibbing their body.

## Changelog

:cl: LT3
qol: Ghosts will now get a notification when someone is about to be hit
by the tram
/:cl:
…n#79341)

Somewhat annoying on occasion, errors thrown from stack_trace() get
combined all into one entry in the runtime viewer. This is because if we
were to create our own exception with properly set information, we would
lose the call stack. To workaround this I've formatted the file and line
number in the exception.name such that it can be extracted in
world.Error and assigned to the correct vars before we handle other
parts of exception handling.


![2023-10-28_06-41-47](https://github.com/tgstation/tgstation/assets/1234602/1a50ad7f-bd6a-4470-b2b0-d373807d1dc1)
@Absolucy
Copy link
Author

Splitting into smaller, more atomized (by comparison) PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet