Remove remove_any from the game (ATTEMPT 2) #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DexeeXI
approved these changes
Jun 7, 2024
|
Upstream port, fixes a problem that the machines indicated have had for some time. |
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation#82020
Why It's Good For The Game
The use of remove_any doesn't really show itself in game outside of one thing.
It completely and utterly fucks over anything beneficial. It just destroys the mixes.
This does affect deathmixes too but in general, the effect is very little.
You can read the port PR for a more detailed description.
Changelog
馃啈
fix: Reagents will now be removed/transferred consistently from cigarettes, smoke machines, etc. rather than at random.
/:cl: