Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports various /tg/ sprites #2365

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Ports various /tg/ sprites #2365

merged 3 commits into from
Jun 26, 2024

Conversation

Absolucy
Copy link

@Absolucy Absolucy commented Jun 22, 2024

About The Pull Request

Once again, more parts from #1810

Ports:

Changelog

馃啈
image: (intercepti0n) Resprites t-ray scanner, gas analyzer, geiger counter and hand drill.
image: (LT3) Medical and improvised gauze are visibly different from cloth.
image: (Alecksohs) Updated the Advanced Surgical Tool's sprites.
code: (Alecksohs) Updated the Advanced Surgical Tool's light code.
/:cl:

Copy link

@ancient-engineer ancient-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems all good but I must ask is keeping

set_light_range(1)

on line 378 intentional or did you forget to remove it

intercepti0n and others added 3 commits June 23, 2024 18:03
## About The Pull Request

Title. The time has come to resprite one of the oldest and soulful
sprites in the game. I really hope you'lll love 'em!


![pleasedonthateme](https://github.com/tgstation/tgstation/assets/137328283/ec2d47ab-aad0-449c-b0a4-7eb66cee39ff)


## Why It's Good For The Game

Remade sprites for t-ray scanner, gas analyzer, geiger counter and hand
drill to fit current art style. Now they look juicier and thicker, i
guess.

## Changelog

:cl:
image: resprites t-ray scanner, gas analyzer, geiger counter and hand
drill.
/:cl:
## About The Pull Request

Adds icons for stacks of medical gauze and improvised gauze, so that
they can be differentiated from stacks of cloth. Currently all 3 look
the same. Medical gauze is blue tinted like the medical tape, improvised
gauze is grey and a smaller size than medical gauze. Both have
attachment clips at the edge of the roll.


![image](https://github.com/tgstation/tgstation/assets/83487515/47bcd42e-7270-498e-aacb-15d5a39fd432)

## Why It's Good For The Game

Easier to tell three different items apart at a glance.

## Changelog

:cl: LT3
image: medical and improvised gauze are visibly different from cloth
/:cl:
Update the sprites of the advanced surgical toolset, giving them
distinct colors and updating their lighting to reduce shades and
increase visual readability at normal resolutions.

![image](https://github.com/tgstation/tgstation/assets/32783144/4daa4f95-2415-4d60-a666-361ebfc52281)

![image](https://github.com/tgstation/tgstation/assets/32783144/b3dfba7b-3db9-42ab-b088-a6e592a3297a)

![image](https://github.com/tgstation/tgstation/assets/32783144/65efec62-aaec-4e86-8a3c-5a57aa08198e)

Currently, the advanced surgical toolset over-relies on the tooltip to
communicate item state quickly and accurately. This PR adds both color
differentials, and enhances the shape of the existing tools to help a
player tell them apart quickly and accurately. Additionally, it assists
in defining the general shape of the item with cleaned up shading to
decrease noisy patterns in the sprite.
:cl:
image: Updated the Advanced Surgical Tool's sprites
code: Updated the Advanced Surgical Tool's light code
/:cl:
Copy link

@ancient-engineer ancient-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good but looking through device.dmi I can't find the new t-ray sprites but I can't with the original PR's dmi either so I guess I'm just blind

@dwasint dwasint merged commit ffc8269 into Monkestation:master Jun 26, 2024
20 checks passed
github-actions bot added a commit that referenced this pull request Jun 26, 2024
@Absolucy Absolucy deleted the tgsprites branch June 26, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants