EMPing a holosign creator will make it delete all its holosigns. #2561
Conversation
It's like if you EMPed a laser, it doesn't destroy it.
|
emp flash random atmos tech |
|
I could make it a chance to have any particular holosign get destroyed, which depends on EMP severity. |
tbf, the holofirelocks break pretty easily. maybe this will incentivize safe work practices in atmos (jk) |
| @@ -82,6 +82,12 @@ | |||
| qdel(H) | |||
| balloon_alert(user, "holograms cleared") | |||
|
|
|||
| /obj/item/holosign_creator/emp_act(severity) // Monke, emping a holosign creator makes it destroy its signs. | |||
| . = ..() | |||
| if(LAZYLEN(signs)) | |||
There was a problem hiding this comment.
early return? What do you mean? (I just copied the sign deletion from the attack_self proc.)
| @@ -82,6 +82,12 @@ | |||
| qdel(H) | |||
| balloon_alert(user, "holograms cleared") | |||
|
|
|||
| /obj/item/holosign_creator/emp_act(severity) // Monke, emping a holosign creator makes it destroy its signs. | |||
There was a problem hiding this comment.
modularize this properly
| /obj/item/holosign_creator/emp_act(severity) // Monke, emping a holosign creator makes it destroy its signs. | ||
| . = ..() | ||
| if(LAZYLEN(signs)) | ||
| for(var/H in signs) |
There was a problem hiding this comment.
this should be a iterator with as anything, also one letter vars bad
|
ADMIN REVIEW: Accepted, this is hilarious |
| @@ -0,0 +1,6 @@ | |||
| /obj/item/holosign_creator/emp_act(severity) | |||
| . = ..() | |||
| if(LAZYLEN(signs)) | |||
There was a problem hiding this comment.
when i say early return, I mean inverting this check and returning if so
| if(LAZYLEN(signs)) | ||
| for(var/sign as anything in signs) | ||
| qdel(sign) | ||
| return |
| /obj/item/holosign_creator/emp_act(severity) | ||
| . = ..() | ||
| if(LAZYLEN(signs)) | ||
| for(var/sign as anything in signs) |
|
finallly, atmos will ahve ot do their job the right way, and not the high tech ghetto way |
About The Pull Request
When you EMP a holosign creator. (Like sec holobarrier.) It will destroy all the holosigns it currently has. The holosign creator will be fine after that and can remake them.
Why It's Good For The Game
Holosign creators are high tech stuff that presumably rely on lots of electrical components. It makes sense that an EMP would disrupt it.
Changelog
🆑
add: EMPing a holosign creator, will destroy all of the holosigns.
/:cl: