Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIF/MP4 support to collection generation #30

Merged
merged 27 commits into from
Apr 7, 2022
Merged

Conversation

Montspy
Copy link
Owner

@Montspy Montspy commented Mar 23, 2022

Allows generating collections of animated GIFs/MP4s.
Supports a mix of animated and static images in traits.py

This PR implements #3

PHP TODO:

  • thumbnail option (thumbnails: true/false)
  • thumbnail size (width required, height optional) (thumbnail_size: [w, h])
  • animated format (option order: .gif, .webm, .mp4) (animated_format)

WIKI TODO:

  • strongly suggest animation dimensions are all identical
  • briefly explain the differences between the 3 format options
  • a note about thumbnails
  • a note about audio channels

@Montspy
Copy link
Owner Author

Montspy commented Mar 23, 2022

Missing from this PR:
Support for MP4
GIF export of MP4 NFTs for the metadata image field

@Montspy Montspy linked an issue Mar 23, 2022 that may be closed by this pull request
@Montspy Montspy marked this pull request as ready for review March 24, 2022 23:17
@Montspy
Copy link
Owner Author

Montspy commented Mar 24, 2022

Now supports GIF, WebM, MP4 as output
And GIF, WebM and MP4 as layer image input

@Montspy
Copy link
Owner Author

Montspy commented Mar 27, 2022

Thumbnails generation in generate.py and support in metadata.py
Specify resolution in traits.py: config["thumbnails"]. If commented out, will not generate thumbnails.
Animated thumbnails are GIF
Static thumbnails are PNG

@sk33z3r sk33z3r mentioned this pull request Apr 4, 2022
6 tasks
@Montspy Montspy linked an issue Apr 4, 2022 that may be closed by this pull request
@sk33z3r sk33z3r added the enhancement New feature or request label Apr 5, 2022
@sk33z3r
Copy link
Collaborator

sk33z3r commented Apr 5, 2022

Documenting for later. Container build is failing when trying to install an ffmpeg library, even when forcing some stuff in apt

Get:505 http://deb.debian.org/debian bullseye/main amd64 va-driver-all amd64 2.10.0-1 [15.3 kB]
Get:506 http://deb.debian.org/debian bullseye/main amd64 vdpau-driver-all amd64 1.4-3 [8540 B]
Get:507 http://deb.debian.org/debian bullseye/main amd64 x11-utils amd64 7.7+5 [202 kB]
Get:508 http://deb.debian.org/debian bullseye/main amd64 x11-xserver-utils amd64 7.7+8 [168 kB]
Get:509 http://deb.debian.org/debian bullseye/main amd64 xauth amd64 1:1.1-1 [40.5 kB]
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/e/expat/libexpat1_2.2.10-2%2bdeb11u2_amd64.deb  404  Not Found [IP: 151.101.130.132 80]
E: Failed to fetch http://deb.debian.org/debian/pool/main/s/systemd/libnss-systemd_247.3-6_amd64.deb  404  Not Found [IP: 199.232.122.132 80]
E: Failed to fetch http://deb.debian.org/debian/pool/main/g/gtk%2b3.0/libgtk-3-common_3.24.24-4_all.deb  404  Not Found [IP: 199.232.122.132 80]
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/o/openssl/libssl-dev_1.1.1k-1%2bdeb11u1_amd64.deb  404  Not Found [IP: 199.232.122.132 80]
E: Internal Error, No file name for libexpat1:amd64
Fetched 197 MB in 1min 9s (2856 kB/s)
The command '/bin/sh -c apt-get install -y --fix-missing python3 npm ffmpeg' returned a non-zero code: 100
ERROR: Service 'php' failed to build : Build failed

looks like the repo just isn't available and returning 404, so maybe it will fix itself at some point today.

@Montspy Montspy merged commit ec84301 into main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants