Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender 2.7 default material is broken for cycles. #272

Closed
TheDuckCow opened this issue Jan 5, 2022 · 4 comments
Closed

Blender 2.7 default material is broken for cycles. #272

TheDuckCow opened this issue Jan 5, 2022 · 4 comments
Labels
bug Known issue This is an existing MCprep behavior that, while not a bug, is known to be problematic for some users
Milestone

Comments

@TheDuckCow
Copy link
Member

For some reason the dropdown for "simple" material is still showing up for blender 2.7, when it shouldn't since the principled node had different inputs or didn't exist (depending on the blender version). Logic needs to be added back in to ensure that the simple option doesn't even show up for blender 2.7

Blender internal continues to work fine as it used different branching logic.

@TheDuckCow TheDuckCow added bug Known issue This is an existing MCprep behavior that, while not a bug, is known to be problematic for some users labels Jan 5, 2022
@TheDuckCow TheDuckCow added this to the v3.3.1 milestone Jan 5, 2022
@StandingPadAnimations
Copy link
Collaborator

I'm just doing a quick check over the code in the prep.py file. I think it may be related to this:
https://github.com/TheDuckCow/MCprep/blob/500a48d96cdc10f8d13172d6ac087a0cbfba2972/MCprep_addon/materials/prep.py#L107-L117

It seems that Blender will only check if the engine is Cycles or EEVEE, and not the version of Blender

@TheDuckCow
Copy link
Member Author

Spot on - though I'm actually thinking it's still useful to show the other two PBR options instead, so might be that we need to set a conditional on the enum (make it a function that returns enum options based on blender version), but then also modify the operator execution code to error out if a bad selection is still inadvertently made (e.g. if called via a python script or something).

TheDuckCow added a commit that referenced this issue Jan 6, 2022
@TheDuckCow
Copy link
Member Author

This has been resolved, but not released yet - will close issue when the patch is out.

@TheDuckCow
Copy link
Member Author

Marking this closed with the imminent release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Known issue This is an existing MCprep behavior that, while not a bug, is known to be problematic for some users
Projects
None yet
Development

No branches or pull requests

2 participants