Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCprep 3.5 - Annotate and docummented util functions #418

Conversation

zNightlord
Copy link
Contributor

@zNightlord zNightlord commented Apr 29, 2023

As part of #401 add annotations to common functions
*edit: Also using f string
And #315 add a README docummented util.py

@zNightlord
Copy link
Contributor Author

@StandingPadAnimations should be good with the anotations and f strings now.
I moved PathLike and VectorType to conf.py because circular import

@TheDuckCow
Copy link
Member

Thanks for working on these changes! Just an FYI that since your branch here is based on top of this PR #401, we'll want to merge that one first before we do this one.

In the end, milestone-3-5-0 is the actual feature branch which will represent MCprep 3.5 (and won't be merged to dev until we're closer to having it all ready)

@TheDuckCow TheDuckCow mentioned this pull request May 3, 2023
6 tasks
@TheDuckCow
Copy link
Member

Will re-review once we have #401 merged into the milestone-3-5-0 branch, seems you'll need to merge mcprep's milestone-3-5-0 branch into your branch here to resolve conflicts with recent changes. Thanks again for proactively working on this!

@StandingPadAnimations StandingPadAnimations deleted the branch Moo-Ack-Productions:mcprep-3_5-recore May 10, 2023 14:40
@TheDuckCow
Copy link
Member

Hey @StandingPadAnimations I noticed you closed this PR, was that intentional?
@zNightlord I believe your changes are still relevant (given my stance on not proceeding with #423)

Might need to re-open a new PR since I can't edit the base branch to be the milestone one.

@StandingPadAnimations
Copy link
Collaborator

Hey @StandingPadAnimations I noticed you closed this PR, was that intentional?

GitHub automatically closes PRs that refer to deleted branches, and recore was deleted after being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants