Settings - Blockchain portfolio #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisboit
requested changes
Dec 6, 2019
src/screens/settings/blockchain-portfolio/blockchain-portfolio.tsx
Outdated
Show resolved
Hide resolved
src/screens/settings/blockchain-portfolio/blockchain-portfolio.tsx
Outdated
Show resolved
Hide resolved
src/screens/settings/blockchain-portfolio/blockchain-portfolio.tsx
Outdated
Show resolved
Hide resolved
src/screens/settings/blockchain-portfolio/blockchain-portfolio.tsx
Outdated
Show resolved
Hide resolved
krisboit
reviewed
Dec 7, 2019
src/screens/settings/blockchain-portfolio/blockchain-portfolio.tsx
Outdated
Show resolved
Hide resolved
maricalucian
reviewed
Dec 7, 2019
a-novi
force-pushed
the
settings-blockchain-portfolio
branch
from
e3cefc4
to
c3ddf94
Compare
a-novi
force-pushed
the
settings-blockchain-portfolio
branch
2 times, most recently
from
c3ddf94
to
e3cefc4
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 46.33% 46.08% -0.26%
==========================================
Files 170 170
Lines 2212 2198 -14
Branches 462 469 +7
==========================================
- Hits 1025 1013 -12
+ Misses 1182 1180 -2
Partials 5 5
Continue to review full report at Codecov.
|
krisboit
requested changes
Dec 9, 2019
| @@ -46,8 +46,6 @@ jobs: | |||
| - uses: actions/setup-ruby@v1 | |||
| with: | |||
| ruby-version: "2.x" | |||
| - name: Generate firebase config file | |||
| @@ -88,8 +86,8 @@ jobs: | |||
| ssh-private-key: ${{ secrets.SSH_CERTS }} | |||
| - name: Add to host | |||
| run: ssh-keyscan gitlab.com >> ~/.ssh/known_hosts | |||
| - name: Generate firebase config file | |||
| @@ -88,8 +86,8 @@ jobs: | |||
| ssh-private-key: ${{ secrets.SSH_CERTS }} | |||
| - name: Add to host | |||
| run: ssh-keyscan gitlab.com >> ~/.ssh/known_hosts | |||
| - name: Generate firebase config file | |||
| run: echo '${{ secrets.FB_CONFIG_IOS_BETA }}' > ios/GoogleService-Info.plist | |||
| - name: Checkout | |||
There was a problem hiding this comment.
this shouldn't be added back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.