Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-Specific Action Bar #1246

Open
JoelProminic opened this issue Jan 31, 2024 · 1 comment
Open

Project-Specific Action Bar #1246

JoelProminic opened this issue Jan 31, 2024 · 1 comment

Comments

@JoelProminic
Copy link
Contributor

I talked with @JustinProminic about adding a second row to the Workspace sidebar that shows the name of the currently selected project and some common actions for the project:
image

The buttons would be configured based on the project type, with an option to override the actions using a configuration file for the project. The buttons should be icons with tooltips, to save space. We could allow arbitrary actions, or focus on common actions like:

  • Build - compilation
  • Launch - Build & Run, or other actions focused on loading a running instance of the project.

The configuration file would be something like moonshine-actions.xml. We could use different formats (JSON, YML, etc. if desired), but I chose XML here to match moonshine-dependencies.xml.

We discussed using a combobox instead of the selected project, but we want to stick with the simple solution for now. We could revisit this later:

  • Advantages:
    • the user can change the project here without needing to scroll or collapse the project tree in the sidebar
  • Disadvantages:
    • This is inconsistent with the current behavior for project actions
    • In my experience with similar interface, I found I sometimes clicked the button without paying noticing that my current project/file was not selected (or I was paranoid about doing that when checking the interface)
@JoelProminic JoelProminic self-assigned this Jan 31, 2024
rat-moonshine pushed a commit that referenced this issue Mar 24, 2024
- Working version of action-build from action-bar
#1246
rat-moonshine pushed a commit that referenced this issue Mar 26, 2024
- Removed XML dependency with plugin-provides action-items
- AS3 project plugin updates to send action-items for sub-types
#1246
rat-moonshine pushed a commit that referenced this issue Mar 27, 2024
@JoelProminic
Copy link
Contributor Author

The initial implementation looks like this:
image

Here is an example of the action configuration. This is currently in the code only:

new ActionItemVO(resourceManager.getString('resources', 'BUILD_PROJECT'), ActionItemTypes.BUILD, HaxeBuildEvent.BUILD_DEBUG),
new ActionItemVO(resourceManager.getString('resources', 'BUILD_AND_RUN'), ActionItemTypes.RUN, HaxeBuildEvent.BUILD_AND_RUN),
new ActionItemVO("Debug", ActionItemTypes.DEBUG, HaxeBuildEvent.BUILD_DEBUG)

We were also talking about highlighting the selected project in the project tree.

rat-moonshine pushed a commit that referenced this issue Apr 2, 2024
- Population of project-based workflows in new panel
#1245
- Moved actionbar into Haxe
#1246
rat-moonshine pushed a commit that referenced this issue Apr 3, 2024
- Removal of workflows on project removal
- Adjustment into actionbar items' visibility
#1245 #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment