Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor masking issue produced by horizontal scrolling #42

Closed
rat-moonshine opened this issue Oct 13, 2017 · 2 comments
Closed

Editor masking issue produced by horizontal scrolling #42

rat-moonshine opened this issue Oct 13, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@rat-moonshine
Copy link
Collaborator

As reported by @JoelProminic in #39 ,

I was able to reproduce the horizontal scroll issue like this:

  1. Create a new FlexJS Project
  2. Make sure that the project is using a FlexJS SDK
  3. Add a long line of code with an error. The line needs to be long enough that it will require a horizontal scroll. I added an example below that will trigger both an error and a warning
  4. Slide the horizontal scroll bar. You should see that the wavy lines do not move
	<fx:Script>
		<![CDATA[
		private var  foo:String = doesNotExist + "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." + doesNotExist2 + " Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.";
		private var bar = "";
		]]>
	</fx:Script>

Unfortunately, I also noticed that the code overlaps with the sidebar.
2017_10_12__sidebaroverlap

Here is my test project, if you need it. I tested with Moonshine 1.6.0 on Mac OS 10.10.5:
2017_10_12__TestHorizontalScroll.zip

@rat-moonshine
Copy link
Collaborator Author

I found a solution, but I need to ensure some more test cases.

@JoelProminic
Copy link
Contributor

I tested with:

  • Maximized window
  • Unmaximized window
  • Changing the width of the editor window by dragging
  • Testing with existing text that exceeded the scrollable threshold
  • Adding new text to exceed the scrollable threshold

I did not see any problems. Additionally, I confirmed that the error and warning lines are still working properly through these tests (see #39).

@piotrzarzycki21 piotrzarzycki21 added this to the v1.7.0 milestone Oct 17, 2017
@piotrzarzycki21 piotrzarzycki21 modified the milestones: v1.7.0, v1.6.1 Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants