-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Domino Visual Editor] Generate Royale Jewel Interface #675
Comments
@JustinProminic I'm not quite sure what do you mean here. If you have in mind having another type of project in Visual Editor where user can create UI interfaces by drag/drop on surface area - same as we have for PrimeFaces etc. - This is rather huger tasks and it should be named differently probably. |
@piotrzarzycki21 we already have a Visual Editor format which outputs to obsolete FlexJS. We need to end support for FlexJS and have it output support for Apache Royale Jewel UI components. At least basic stuff. Field labels, field input, etc. The basic functionality we had from the FlexJS visual builder should be able to fairly easily be re-purposed to use Jewel components in the UI definition file that is generated for Royale. @rat-moonshine please add your thoughts. |
I probably a little confused, @JustinProminic . I believe we decided to obsolete FlexJS long back in Moonshine. I don't see we have any support for FlexJS either, Perhaps, you meant about Visual Editor support that we have for Flex and PrimeFaces? I think I understood that you wants same mock-up support for Royale Jewel projects, too - whether you wants to remove any existing type (Flex, PrimeFaces) and add Jewel, or it'll be just a new addition, that is not clear to me. I don't think we output for FlexJS through Visual Editor, though. |
@rat-moonshine @piotrzarzycki21 @JoelProminic Visual Editor project needs to support - in the long run (no particular order here):
and when Josh is ready: These are the value added features that make Moonshine truly unique, and harken back to the Flash/Flex Builder days (but not attempting round-trip like it did). So, if I misunderstood where we are at with the FlexJS code, we can talk about that on the next Wednesday meeting. I was merely trying to lay out the roadmap for updating this feature so that those kicking the tires on Royale Jewel components can use the existing Visual Editor to create a very basic form without coding. |
Furthermore, we had an entire system we built a while ago that would take Notes/Domino forms and convert them to FlexJS. I'm pretty sure the intermediate format was the Visual Editor XML. So the flow was Notes/Domino DXL -> Visual Editor -> FlexJS. @JoelProminic am I misremembering this? |
@JustinProminic We have never had in Visual Editor output to FlexJS, unless I'm not aware of something and code is laying somewhere on the Prominic sight where I don't have access. As @rat-moonshine said we do have output in Visual Editor to Flex and PrimeFaces. Making Visual Editor for Royale Jewel is something new and unexplored yet. |
We need to discuss on feasibility of this requirement since this issue is long opened and moving through milestones. As I understand FlexJS is now dominates by its next generation RoyaleJS. Although, it appears that Apache still distributes FlexJS source through their website. An issue like this is breadth of a milestone, do we want to keep this into our queued tasks? |
@feather812002 @rat-moonshine @JoelProminic @piotrzarzycki21 I have just sent you direct e-mail subject "Moonshine IDE -- Notes Client to FlexJS prototype -- Fix Visual Editor to output Royale Jewel components instead of FlexJS #675" dated: Please read it as it has the details on our past efforts on this aspect of conversion. |
@rat-moonshine no it's not "dominates" - It is exactly the same framework. We have changed project name to do not connect project fully with Flex. |
Yep and it will be. Each release is archived so there is no way it will just disappear. I'm not sure where do you see that but it will stay for sure. |
@piotrzarzycki21 It could be, that FlexJS and Royale are same (because of the underlaying framework both uses) - but as a layman I see both are different products (I'm sure we also puzzled between using which products by their names), and suggested to use Royale over FlexJS. I've seen the distribution at here: https://flex.apache.org/download-flexjs.html. |
In any case, I would expect the FlexJS code from our previous work to be obsolete at this point. I think we will probably be better off using the templates from #704 as an example. @feather812002, take a look at the template created by @piotrzarzycki21. We will probably need some more examples to implement all of the DominoVisualEditor options, but this will be a good place to start. |
@feather812002 is getting ready to switch to this task, so I wanted to supply some useful references:
|
Unfortunately, I found that the example project was failing:
I did some minimal fixes to resolve the compilation errors, but I see that I can't submit the forms now. @rat-moonshine or @piotrzarzycki21, can you revisit this template when you have a chance. We can discuss this in more detail in the meeting tomorrow. |
What version of Apache Royale did you use to build that example ? I just tried it and I'm able build with official release 0.9.8 and fresh nightly 0.9.9. |
Does that means this basic template-codes is still valid with latest Royale nightly, and without any break? |
It looks like it is. |
I meant to discuss this in the meeting today, but it is just as well that we missed it with how late the meeting ran. I tested with 0.9.9. I think this instance was a few weeks old though. To be clear, I got the error on the previous example here. I resolved the compilation errors with my updated example. However, I'm seeing that the submit button on the form doesn't do anything currently. Does this need to call some external API? I didn't notice any errors on the browser console in my test. |
…h in Royale - output container instead P (reference Moonshine-IDE/Moonshine-IDE#675)
…h in Royale - output container instead P (reference #675)
in Generated Project to Apache Royale (reference #675)
@JoelProminic I didn't put a notes. Do you remember if priority was in that order:
|
The priorities I noted from yesterday's meeting were:
For the newline issue, I see that some of these cases have the command label and the field in the same paragraph (i.e. I consider the same paragraph cases a bug in the conversion process. I'll create a separate issue for this after I retest. We'll need to clarify the definition of the Paragraph component for the separate paragraphs case. We could either add clarification that Paragraph always indicates a separate line, or we can update the converted database to use vertical layout for the parent. I'll keep you updated on this. For the read-only and edit modes, I see two common use cases:
We can brainstorm how we want to support these two cases.
We could handle the read-only and edit modes like we do for the MyDetails section in MyAccount. This logic seems clean on the UI side, but I'm not sure how well it would work for generated code. |
Thanks @Aszusz, I didn't see this when I was comparing the interfaces yesterday. There will probably be other backslashes in the commands, so watch the escaping on this. I can see some other examples in your screenshot: This is an unusual case that I wouldn't expect to see in other database, but this is one of the key databases we want to convert. |
…n isDisabled property added to each file (reference Moonshine-IDE/Moonshine-IDE#675)
…ng forms readonly on demand (reference Moonshine-IDE/Moonshine-IDE#675)
…ted forms to Royale - Update Joditeditor for royale conversion with readonly property (reference #675)
I have pushed changes related to "readonly" form to master. The changes I made is that every form has property which allows switch between readonly/edit mode. Once you convert domino project to Royale and open any view you will see inside property called However I'm not sure to which direction I should go from that point. I see two options:
Thoughts ? |
This part is something which may causes more issues. If parent of my paragraph has other children - not necessary paragraphs we may have them positioned in a weird way. Unless by that sentence you are saying about paragraph itself with children - and making that container vertical. @JoelProminic please discuss this paragraph issue with Justin. I may not be able to join Wednesday's meeting, but I would like to have it implemented so you will be able to try it out. |
@JoelProminic just to be clear this code is being considered as a bug ? Cause it translates in Moonshine as a one paragraph, but it should be two actually ?
I need to wait till you fix that ? Currently we have following situation after conversion to Royale:
Each new paragraph is going to the new line. Is this how I should preserve that ? |
@piotrzarzycki21, your first example (from "ConfigValue") is correct as-is. The label and the field are on the saem line in this case. The layout should be like:
The problem is this case, from Host Config Snapshot:
This example only has a single See #1033 for more details. In the meantime, you can treat the single |
…raph and Div container - Dispaly information about layout direction (reference Moonshine-IDE/Moonshine-IDE#675)
It is time we address this... FlexJS should be removed, in favor of Royale Jewel component output.
The general goal is for someone to build a working Royale Jewel application within 5 minutes after installing Moonshine, and no more than 10 mouse clicks.
The text was updated successfully, but these errors were encountered: