Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "New" -> "Visual Editor Flex File" should be disabled for other type of projects than Visual Editor #84

Closed
piotrzarzycki21 opened this issue Nov 29, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@piotrzarzycki21
Copy link
Collaborator

In context menu in project tree option "New" -> "Visual Editor Flex File" should be disabled for other type of projects than Visual Editor.

I think this issue could be introduced by changes in #62. I did reset master to the committs before changes and it was working.

@rat-moonshine
Copy link
Collaborator

Context menus' enable/disable state against VE projects, now fixed.

While working on the above fix, I noticed following problem in case of VE project in File/New menu:

untitled-1

I noticed MenuUtils.menuItemsDisabledInVEProject has a static Array which were using to enable menus in case of VE projects in File/New (perhaps @piotrzarzycki21 you want to consider renaming this array as it's using to enable menus but disable).

This menu generation is now dynamic at the time of template parsing, this also includes custom templates. Custom template addition/removal/renaming also updates the collection now.

#83 changes also affected File/New enable/disable states between VE and non-VE projects, it's fixed now.

@piotrzarzycki21
Copy link
Collaborator Author

@rat-moonshine I have changed mentioned property to menuItemsEnabledInVEProject. I hate that solution but couldn't come up with better one in current architecture of Menu. I was thinking even about rewrite completely Menu where we will have XML for configuration what is inside and what is not, but that would take too much time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants