add expected blocktime to pallet_async_backing #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
changed the title
Agusrodri
approved these changes
Mar 14, 2024
tmpolaczyk
reviewed
Mar 14, 2024
| @@ -94,6 +94,9 @@ pub mod pallet { | |||
|
|
|||
| /// A way to get the current parachain slot and verify it's validity against the relay slot. | |||
| type GetAndVerifySlot: GetAndVerifySlot; | |||
|
|
|||
| #[pallet::constant] | |||
| type ExpectedBlockTime: Get<Self::Moment>; | |||
There was a problem hiding this comment.
Maybe add a comment that this is used by tools like chopsticks, to prevent future developers from accidentally removing it
tmpolaczyk
approved these changes
Mar 14, 2024
librelois
approved these changes
Mar 14, 2024
girazoki
added a commit
to moondance-labs/moonkit
that referenced
this pull request
Mar 15, 2024
* add expected blocktime * add commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds expected blocktime to
pallet_async_backing. This is purely informative but it helps cases where this needs to be known (e.g., mocking tools like chopsticks).Similar to Babe: https://github.com/paritytech/polkadot-sdk/blob/3c6ebd9e9bfda58f199cba6ec3023e0d12d6b506/substrate/frame/babe/src/lib.rs#L135