Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track child process information #11

Closed
erikhuck opened this issue Mar 25, 2024 · 3 comments
Closed

Track child process information #11

erikhuck opened this issue Mar 25, 2024 · 3 comments

Comments

@erikhuck
Copy link
Collaborator

erikhuck commented Mar 25, 2024

It could be helpful to not only track the maximum gpu ram and ram over the main process and its children but to also give more granular data i.e. the ram of the main process alone followed by the individual measurements for each of its children. It could have a dictionary that maps the "main" process and each of its children (by process ID) to a dictionary containing a "max_ram" and "max_gpu" field. The overall max_ram and max_gpu can then be calculated from that dictionary rather than being calculated directly.

The tracker should probably have a verbose flag that displays just the summed information vs. the more granular version.

@hunter-moseley
Copy link
Member

hunter-moseley commented Mar 25, 2024 via email

@erikhuck
Copy link
Collaborator Author

This actually may not be the most viable in the case that a user's main process spawns several different child processes, constantly closing one and starting another. There could be information collected for very many different child processes which only existed for a relatively brief period of time. If we do implement this, we may want to include a warning in the documentation informing them that a lot of memory could be used by the Tracker itself if their process spawns a bunch of child processes so they can choose to keep this setting as False if desired.

@hunter-moseley
Copy link
Member

hunter-moseley commented Mar 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@hunter-moseley @erikhuck and others