Fix/129 performance #131
Merged
Fix/129 performance #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of NSNumber and using `initWithCString` instead of `stringWithFormat:`.
…t we can test it easily for performance impact.
…SNumber each time willDisplayCell:inContext: is called.
…straints:` inside CKCalendarHeaderView.
… the property accessor.
…wLayout - we're going to compute this in the calendar model's animation support category and cache it. This eliminates duplicate work.
… per cell in the CKCalendarGridTransitionCollectionViewFlowLayout.
- Rename `CKContextCache` to `CKCalendarCellContextCache`. - Observe low memory notification. - Observe significant time change notification. - Take the calendar view as an initialization parameter. - Remove manual insertion method. - Use the shared date formatter instead of generating string keys on our own.
…ference to the context for today.
…he calendar view.
…endar view based on the model.
…ate` and`computedLastVisibleDate`.
…ew. This allows us to more easily update the highlighted cell as the user scrubs.
…ay of the week isn't sunday.
…tly. This allows the model to invalidate caches as necessary and let us know when to reload. This also means that the calendar view no longer reloads inside of this setter.
…ws - this works since we're only caching resizing the cached image view at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance when selecting a new date, bringing re-render time without cache invalidation to under 200ms, and with cache invalidation to about 450ms.
It also fixes issues #73, #110, and #127.