Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Toggle Issue Comments) Clicking on the avatars in the popup menu no longer toggles the comments from the relevant users #60

Closed
darkred opened this issue Oct 3, 2018 · 5 comments
Labels

Comments

@darkred
Copy link
Collaborator

darkred commented Oct 3, 2018

Using Chrome 69/Firefox 62 (also in fresh profiles), TM 4.8.5850 beta, GitHub Toggle Issue Comments 1.3.2.

Unfortunately clicking on the avatars in the popup menu no longer toggles the comments from the relevant users.

There's no error in Console.

@darkred darkred added the bug label Oct 3, 2018
@darkred darkred changed the title (GitHub Toggle Issue Comments) Clicking on their avatar in the popup menu no longer toggle comments from specific users (GitHub Toggle Issue Comments) Clicking on the avatars in the popup menu no longer toggles the comments from the relevant users Oct 3, 2018
@Mottie
Copy link
Owner

Mottie commented Oct 5, 2018

Thanks for reporting this issue! Fixed in 8b65f6b.

@Mottie Mottie closed this as completed Oct 5, 2018
@darkred
Copy link
Collaborator Author

darkred commented Oct 5, 2018

First of all thank you!

Now it works ok in many pages I tested.
In one page though https://github.com/hayaku/hayaku/issues/303 ,
with the new version the users list in the popup menu
now appears duplicated 2 times (shown with the red arrows) :
2018-10-05_165914 2018-10-05_165959

This didn't occur in previous script version 1.3.2.
Tested in a fresh Chrome/FF Profile with only TM beta and the script -the screenshots are from Firefox- .

@darkred
Copy link
Collaborator Author

darkred commented Oct 5, 2018

FYI, the above issue page https://github.com/hayaku/hayaku/issues/303
has 6 "x similar comments" and 1 "y hidden items",
all because of this new GitHub feature: Hiding repeat comments .

On the other hand, the new issue I describe, i.e. the duplicated users list, doesn't occur in e.g. https://github.com/isaacs/github/issues/253#issuecomment-422328717
which has has 2 "x similar comments" and 1 "y hidden items".

@Mottie
Copy link
Owner

Mottie commented Oct 6, 2018

Fixed. I added a hide similar comments toggle as well.

@darkred
Copy link
Collaborator Author

darkred commented Oct 6, 2018

Awesome ! Thanks ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants