ethiopic #562
Merged
ethiopic #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mottie
reviewed
May 11, 2017
languages/amh.js
Outdated
| // Keyboard Language | ||
| // please update this section to match this language and email me with corrections! | ||
| // "all" is used here for example purposes, by convention it should be the ISO 639-1 code for the specified language | ||
| // *********************** |
There was a problem hiding this comment.
Would you please give yourself and Dr. Beyene credit in the comment section!
There was a problem hiding this comment.
done, I hope is ok!
Mottie
reviewed
May 11, 2017
languages/amh.js
Outdated
| // please update this section to match this language and email me with corrections! | ||
| // "all" is used here for example purposes, by convention it should be the ISO 639-1 code for the specified language | ||
| // *********************** | ||
| jQuery.keyboard.language.all = { |
There was a problem hiding this comment.
Please replace the "all" with the language abbreviation for Ethiopic... I tried to find one using ISO-639-3 language codes, but it isn't listed.
|
Please fix the
|
although this works also for gez which is our main purpose.
|
I failed to find in amh.js the second all. |
|
Hehe sorry, the first was the comment line I asked you to remove. It looks good, thank you again! |
|
thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethiopic keyboard layout and language file with combos to support amahric and geez. Translation in language file by Dr. Solomon Gebreyes Beyene. It also contains diacritics for transliteration.