fixed some functions might fail if not given a string

[Andreas-Hjortland]

isDigit and one of the ts.addParser.is would fail if you did not give it a string,
so I just added s.toString() when doing the regex matches.

[thezoggy]

can you resubmit your changes without modifying the line ending? as it shows that you modified every line.. thus making it really hard to tell what you even changed..

[Andreas-Hjortland]

I sorry. I will do it right away

[Mottie]

It looks like you just added a toString() here:

this.isDigit = function(s) {
    // replace all unwanted chars and match.
    return (/^[\-+(]?\d+[)]?$/).test(s.toString().replace(/[,.'\s]/g, ''));
};

Please don't bother with a pull request. I had a hard time merging the last one into my current working code (I still suck at git LOL)... I hope I'll get v2.4 out there soon, with this change of course! ;)

[Andreas-Hjortland]

It was just that. I suck at git myself as I almost have no experience with it. Good luck with further development of the library ^^

Fra: Rob G [mailto:notifications@github.com]
Sendt: 16 August 2012 17:18
Til: Mottie/tablesorter
Kopi: Andreas Hjortland
Emne: Re: [tablesorter] fixed some functions might fail if not given a string (#121)

It looks like you just added a toString() here:

this.isDigit = function(s) {
// replace all unwanted chars and match.
return (/^[-+(]?\d+[)]?$/).test(s.toString().replace(/[,.'\s]/g, ''));
};

Please don't bother with a pull request. I had a hard time merging the last one into my current working code (I still suck at git LOL)... I hope I'll get v2.4 out there soon, with this change of course! ;)

—
Reply to this email directly or view it on GitHub #121 (comment) .

https://github.com/notifications/beacon/rBvDsDai0B5X7hPgvVK0Rif2Sfh6jcLyKS_KbCBW8Gl34CKFiwwPNQR5c4nXpuEv.gif

[Mottie]

I just realized I did modify the isDigit function to prevent problems with non-strings:

ts.isDigit = function(s) {
    // replace all unwanted chars and match
    return isNaN(s) ? (/^[\-+(]?\d+[)]?$/).test(s.replace(/[,.'\s]/g, '')) : true;
};

so we probably don't need the s.toString(), but I think I'll go ahead and add it just in case :P

[Andreas-Hjortland]

isNaN evaluates to true for undefined, which doesn’t have a replace function, so I still think a toString() will be applicable. I also noticed that this function will return true if you give it a Boolean value, because isNaN(true) and isNaN(false) evaluates to false. Which then returns true ^^

Fra: Rob G [mailto:notifications@github.com]
Sendt: 19 August 2012 06:54
Til: Mottie/tablesorter
Kopi: Andreas Hjortland
Emne: Re: [tablesorter] fixed some functions might fail if not given a string (#121)

I just realized I did modify the isDigit function to prevent problems with non-strings:

ts.isDigit = function(s) {
// replace all unwanted chars and match
return isNaN(s) ? (/^[-+(]?\d+[)]?$/).test(s.replace(/[,.'\s]/g, '')) : true;
};

so we probably don't need the s.toString(), but I think I'll go ahead and add it just in case :P

—
Reply to this email directly or view it on GitHub #121 (comment) .

https://github.com/notifications/beacon/rBvDsDai0B5X7hPgvVK0Rif2Sfh6jcLyKS_KbCBW8Gl34CKFiwwPNQR5c4nXpuEv.gif