Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue that occurred when you try to download table data as CSV #1373

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

ruchir19
Copy link
Contributor

Fixed an issue that occurred when you try to download table data as CSV with multiple headers and Colspan greater than 3. It caused column header alignment problem when I export out.

Here is the table which was causing problem.
workspaces

…SV with multiple headers and Colspan greater than 3. It caused column header alignment problem when I export out.
@Mottie
Copy link
Owner

Mottie commented Mar 30, 2017

Hi @ruchir19!

Thanks for taking the time to submit a PR... I can't tell that the change made any difference in the two demos I set up:

Current code (demo)

Output

Case Type,Total Case Count,Total No. of Rooms,Total Room Idle Time,Total Case Count,Total No. of Rooms,Total Room Idle Time
A,15,5,20,12,7,21
C,25,4,10,12,6,12
B,13,4,33,12,7,16

PR code (demo)

Output

Case Type,Total Case Count,Total No. of Rooms,Total Room Idle Time,Total Case Count,Total No. of Rooms,Total Room Idle Time
A,15,5,20,12,7,21
C,25,4,10,12,6,12
B,13,4,33,12,7,16

Is there something in the HTML that I'm missing?

@ruchir19
Copy link
Contributor Author

Hi @Mottie ,

Thanks for getting back to me. I am using similar HTML. Problem occurs when we try to export CSV with both the header rows by enabling widgetOptions. I have forked your demos with some more columns and included widgetOptions in JS.

Current Code (demo)

Notice that it skipped top header alternatively for 2016 Q1 and 2015 Q3 while exporting CSV resulting column header alignment problem

PR Code (demo)

PR fixes that issue.

Please feel free to message me if you find any other issue regarding this.

@Mottie
Copy link
Owner

Mottie commented Mar 30, 2017

Ok, that looks good then! Thanks again!

@Mottie Mottie merged commit c6db0bc into Mottie:master Mar 30, 2017
@ruchir19
Copy link
Contributor Author

NP. Happy to Contribute. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants