-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加对discord适配器的支持 #69
增加对discord适配器的支持 #69
Conversation
✅ Deploy Preview for send-anything-anywhere canceled.
|
✅ Deploy Preview for send-anything-anywhere canceled.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 94.92% 93.87% -1.06%
==========================================
Files 18 19 +1
Lines 1222 1339 +117
==========================================
+ Hits 1160 1257 +97
- Misses 62 82 +20
☔ View full report in Codecov by Sentry. |
没有办法通过这个test,需要在test的workflow里面加上一行pip install git+https://github.com/CMHopeSunshine/adapter-discord.git@dev来安装discord适配器才能正常运行discord的test,在本机测试没有问题,可以直接merge了 |
为什么不拆成两个 PR 呢?增加返回值和适配 discord 应该分开吧。 |
在发布到 pypi 之前,你可以用 |
测试覆盖率写不上去了,你看看改改吧,不行直接merge |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 94.92% 94.66% -0.27%
==========================================
Files 18 19 +1
Lines 1222 1311 +89
==========================================
+ Hits 1160 1241 +81
- Misses 62 70 +8
|
实现一下 receipt,撤销对其他 adapter 的更改 |
自己试了一下不支援外部注册discord适配器,文件的说明也不详细,交给你这个merge request了,希望 discord 适配器能尽快出现 |
👷 Deploy request for send-anything-anywhere pending review.Visit the deploys page to approve it
|
阿巴阿巴,push歪了,没加HEAD |
重新试试( |
本来想在保留你pr的前提下在里面改改,不用另开pr了( |
之前备份了一下,你原来的分支内容可以在 canxin/discord 里找回 |
适配discord的文,图,mention,reply