Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加对discord适配器的支持 #69

Closed
wants to merge 0 commits into from

Conversation

canxin121
Copy link
Contributor

@canxin121 canxin121 commented Aug 13, 2023

适配discord的文,图,mention,reply

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for send-anything-anywhere canceled.

Name Link
🔨 Latest commit 7a4d664
🔍 Latest deploy log https://app.netlify.com/sites/send-anything-anywhere/deploys/64d8616d36f2830008c2b74f

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for send-anything-anywhere canceled.

Name Link
🔨 Latest commit 308316a
🔍 Latest deploy log https://app.netlify.com/sites/send-anything-anywhere/deploys/64d8982fca9e3300083d97bd

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 84.73% and project coverage change: -1.06% ⚠️

Comparison is base (b6323da) 94.92% compared to head (308316a) 93.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   94.92%   93.87%   -1.06%     
==========================================
  Files          18       19       +1     
  Lines        1222     1339     +117     
==========================================
+ Hits         1160     1257      +97     
- Misses         62       82      +20     
Files Changed Coverage Δ
nonebot_plugin_saa/adapters/kaiheila.py 93.61% <60.00%> (-1.94%) ⬇️
nonebot_plugin_saa/adapters/qqguild.py 84.04% <66.66%> (-2.48%) ⬇️
nonebot_plugin_saa/adapters/onebot_v11.py 95.90% <75.00%> (-0.74%) ⬇️
nonebot_plugin_saa/adapters/feishu.py 92.85% <80.00%> (-0.98%) ⬇️
nonebot_plugin_saa/adapters/onebot_v12.py 95.26% <80.00%> (-0.52%) ⬇️
nonebot_plugin_saa/adapters/telegram.py 87.80% <83.33%> (-0.51%) ⬇️
nonebot_plugin_saa/adapters/discord.py 87.20% <87.20%> (ø)
nonebot_plugin_saa/__init__.py 100.00% <100.00%> (ø)
nonebot_plugin_saa/adapters/__init__.py 100.00% <100.00%> (ø)
nonebot_plugin_saa/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canxin121
Copy link
Contributor Author

canxin121 commented Aug 13, 2023

@he0119
Copy link
Contributor

he0119 commented Aug 13, 2023

为什么不拆成两个 PR 呢?增加返回值和适配 discord 应该分开吧。

@he0119
Copy link
Contributor

he0119 commented Aug 13, 2023

没有办法通过这个test,需要在test的workflow里面加上一行pip install git+https://github.com/CMHopeSunshine/adapter-discord.git@dev来安装discord适配器才能正常运行discord的test,在本机测试没有问题,可以直接merge了

在发布到 pypi 之前,你可以用 poetry add --group dev git+https://github.com/CMHopeSunshine/adapter-discord.git 添加到 dev 里,也能够在测试的时候安装。

@canxin121
Copy link
Contributor Author

测试覆盖率写不上去了,你看看改改吧,不行直接merge

@canxin121 canxin121 changed the title 增加对discord适配器的支持,增加send和send_to方法的返回数据 增加对discord适配器的支持 Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #69 (4c94cc8) into main (b6323da) will decrease coverage by 0.27%.
The diff coverage is 92.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   94.92%   94.66%   -0.27%     
==========================================
  Files          18       19       +1     
  Lines        1222     1311      +89     
==========================================
+ Hits         1160     1241      +81     
- Misses         62       70       +8     
Files Changed Coverage Δ
nonebot_plugin_saa/adapters/onebot_v11.py 96.63% <ø> (ø)
nonebot_plugin_saa/adapters/discord.py 90.12% <90.12%> (ø)
nonebot_plugin_saa/__init__.py 100.00% <100.00%> (ø)
nonebot_plugin_saa/adapters/__init__.py 100.00% <100.00%> (ø)
nonebot_plugin_saa/adapters/feishu.py 93.82% <100.00%> (ø)
nonebot_plugin_saa/adapters/kaiheila.py 95.55% <100.00%> (ø)
nonebot_plugin_saa/adapters/onebot_v12.py 95.78% <100.00%> (ø)
nonebot_plugin_saa/adapters/qqguild.py 86.51% <100.00%> (ø)
nonebot_plugin_saa/adapters/telegram.py 88.31% <100.00%> (ø)
nonebot_plugin_saa/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

@felinae98
Copy link
Collaborator

实现一下 receipt,撤销对其他 adapter 的更改

@eric2788
Copy link

自己试了一下不支援外部注册discord适配器,文件的说明也不详细,交给你这个merge request了,希望 discord 适配器能尽快出现

Copy link

netlify bot commented Jun 9, 2024

👷 Deploy request for send-anything-anywhere pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 84ed0ec

@AzideCupric
Copy link
Contributor

阿巴阿巴,push歪了,没加HEAD

@AzideCupric
Copy link
Contributor

重新试试(

@AzideCupric
Copy link
Contributor

本来想在保留你pr的前提下在里面改改,不用另开pr了(
但是push的时候忘记HEAD:main了,pr自己关掉了(((
不好意思喵

@AzideCupric
Copy link
Contributor

之前备份了一下,你原来的分支内容可以在 canxin/discord 里找回

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants