Fix channel_axis bug in transforms.py #688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug while running the command line version of the tool. If you give it a multi-z multi-channel image with a dimension order of (z, ch, y, x) (as suggested in the documentation) and correctly set the --z_axis parameter to 0 and the --channel_axis parameter to 1, this chunk of code in convert_image() of transforms.py:
shouldn't change the image at all since the z_axis is already first but it will still add 1 to channel_axis, making it wrong because the z_axis wasn't moved. Adding an additional check before running this chunk to make sure the z_axis needs to be moved fixes this.