Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarCloud alert #16

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix SonarCloud alert #16

merged 1 commit into from
May 15, 2024

Conversation

sjwmoveon
Copy link

@sjwmoveon sjwmoveon commented May 15, 2024

Fixes Sonarcloud error.

Description

SonarCloud doesn't like raw http links, preferring https. In this case the link should never be used so it makes no difference to switch to https.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • N/A I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

SonarCloud doesn't like raw http links, preferring https.  In this case the link should never be used so it makes no difference to switch to https.
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjwmoveon sjwmoveon merged commit 5941cc5 into main May 15, 2024
14 checks passed
@sjwmoveon sjwmoveon deleted the sjwmoveon-patch-1 branch May 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants