V1.4 Final tweaks #101
Merged
V1.4 Final tweaks #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… newer Gradle. Moves around some code analytics as well.
- last equipment commit left NPC ships without anything equipped (but the player with better equip logic). Now there are distinct blocks for PC vs NPC. - default config file for a new player ship updated to the new format so stuff will load first time. - under a rare condition (unknown details) a block with an engine item could be encountered that would terminate the game, yet just skipping that seemed to leave nothing broken.
|
Hooray Jenkins reported success with all tests good! |
|
More Android tweaks applied in the other repo. Played for a good half hour via beta release on Google Play. Looking pretty good! Also got smushed on the surface twice, first by an oversized meteor then by the traveling marketplace ship crashing into the planet. That one actually made me laugh out loud :-) Checking Steam build next then done at long last. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, anyway :-)
I found a rather critical bug in the last round of equipping logic changes - NPC ships were no longer equipping stuff, whoops! Wouldn't I feel silly if I was the supposed tester who missed that. Which I was so... yeah. Nice going me!
Took me an odd amount of time to figure out, probably in part from being out of practice and from the equipping logic being shared a bit funny between player, NPCs, etc. Mercs too I suspect but something still seems to keep them from firing :/
They were already borderline broken anyway, so forging onward. Fix for now was simply using the new logic only if the "pilot" being processed is the player, if not use the old logic.
Found and fixed one related bug where a later format change hadn't been applied to the player's default starting config, resulting in nothing being equipped. And during my long journey I rarely encountered a crash bug (is it a crash bug if the game commits suicide when it detects a state it doesn't like?) which it seems the game can actually bypass with no apparent ill effect.
Hopefully.
On a completely different note recent Gradle changes had left the Android part broken as well, which can happen easily since we still haven't got it building automatically on commit / for testing new PRs. Hey I wonder whose job that's supposed to be, hmm.
TODO when merging: