no benefit in using guardlog. #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert commented on pr: MovingBlocks/Terasology#5154 that the rule is not really beneficial and better remove the rule than suppress it.
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 1, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 8, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 8, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 8, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 9, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com> squash later Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 9, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 9, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 10, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 10, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
|
Will be discussed in our next reviver meeting (tomorrow, Sunday 7PM UTC) |
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 11, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
|
we decided yesterday to keep the rule. |
|
There's an open issue on PMD regarding the |
|
Let's temporarily exclude the rule but with a TODO to reinclude it once the PMD issue (link it) is fixed. |
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 17, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 17, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 17, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
jdrueckert
reviewed
Nov 17, 2023
| @@ -7,7 +7,6 @@ | |||
| Terasology PMD ruleset | |||
| </description> | |||
| <exclude-pattern>.*/org.terasology.protobuf/.*</exclude-pattern> | |||
| <!-- inline <rule ref="rulesets/java/basic.xml"/> --> | |||
There was a problem hiding this comment.
why are we removing these comments?
|
If the usage of suppliers sufficiently fixes the findings such that PMD doesn't report them anymore despite the open PMD bug, maybe we don't need this after all. |
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 17, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
soloturn
added a commit
to soloturn/terasology
that referenced
this pull request
Nov 18, 2023
especially take out pmd guardlog suppresses. fix part of them in a catch even if not necessary from a performance point of view. and create a pull request towards teraconfig to not use the guardlog rule any more: MovingBlocks/TeraConfig#23 Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jdrueckert commented on pr: MovingBlocks/Terasology#5154 that the rule is not really beneficial and better remove the rule than suppress it.
as well remove the not any more necessary comments.