Crash when using the W&S workstation

[BrazenDynamo]

Logfile here: http://pastebin.com/jnj3j20j

I don't know why, but when I try opening the subfolder for "Planks" under "Buildings", the game crashes. D:

[Cervator]

Confirmed! Able to reproduce with the latest build. It isn't just you :-)

Central log snippet:

01:30:12.208 [main] WARN  org.terasology.asset.AssetManager - Unable to resolve asset: shape:Engine:StructuralResources:PillarTop
01:30:12.209 [main] WARN  o.t.w.b.internal.BlockManagerImpl - Failed to resolve block family 'Core:Plank:Engine:StructuralResources:PillarTop'
01:30:12.213 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception
java.lang.NullPointerException: null
    at org.terasology.was.system.PlankBlockRecipe$PlankBlockRecipeResultFactory.getBlock(PlankBlockRecipe.java:67) ~[na:na]
    at org.terasology.crafting.system.recipe.render.result.BlockRecipeResultFactory.setupDisplay(BlockRecipeResultFactory.java:67) ~[na:na]

The issue is from when we moved some shapes to the StructuralResources module from the engine. The addPlankBlockShapeRecipe helper method in RegisterWoodAndStoneRecipes (in the WoodAndStone module) is hard coded to use shapes from "Engine" and we end up with something like shape:Engine:StructuralResources:PillarTop

This isn't a hard fix, could probably sort something out, but I wonder how @MarcinSc would prefer it fixed - you out there Marcin?

Helper method in question:

    private void addPlankBlockShapeRecipe(String shape, int ingredientMultiplier, int durabilityMultiplier, int resultMultiplier) {
        addPlankBlockShapeRecipe(shape, "Engine", ingredientMultiplier, durabilityMultiplier, resultMultiplier);
    }

There is another spot in the same class that may also need to be more dynamic (line 197)

[Cervator]

@BrazenDynamo - try this now? I triggered a rebuild of the main game distribution (unstable version) after @MarcinSc applied a couple fixes to the WoodAndStone module

http://jenkins.movingblocks.net/job/Terasology/lastSuccessfulBuild/artifact/build/distributions/Terasology.zip

[BrazenDynamo]

@Cervator Just tried it- it's working fine now! :D
I'll play around with it more and report if there are any other issues.

[Cervator]

Good to hear :-)

If you find any related issues check the WoodAndStone tracker + Jenkins jobs in case they're known or fixed. I rebuilt the main game distribution just to re-bundle the latest version, but Marcin might make more fixes you can grab directly even without a new game distribution

https://github.com/Terasology/WoodAndStone
http://jenkins.movingblocks.net/view/Modules/job/WoodAndStone/