Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for auto-downloading modules if server if running from source #2381

Open
Cervator opened this issue Jun 27, 2016 · 2 comments
Open
Assignees
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Good First Issue Good for learners that are new to Terasology

Comments

@Cervator
Copy link
Member

Cervator commented Jun 27, 2016

I expect this is because the auto-download in the server expects to find module jar files under /modules rather than source directories. I would like for us to catch that situation better and log it, then maybe attempt to find built jars (modules/[module]/build/libs/[module-[version].jar]) if present.

The logging would need to include a disclaimer that if the goal is to have a server running from source successfully serving modules the developer would have to run gradlew jar first to make sure there are actually built jar files present.

To clarify: just improving the logging sufficiently would be enough to close this issue.

Edit: Discovered this while testing #2379 which has some related stuff.

@Cervator Cervator added Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Good First Issue Good for learners that are new to Terasology labels Jun 27, 2016
@TheFlash98
Copy link
Member

Hey @Cervator can you suggest some place to start looking?

@Cervator
Copy link
Member Author

You found it before I had a chance, nice work :)

Assigning this to you since there is a pending PR with another question open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Good First Issue Good for learners that are new to Terasology
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants