Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflective water tweaks #285

Closed
Cervator opened this issue Jul 29, 2012 · 3 comments
Closed

Reflective water tweaks #285

Cervator opened this issue Jul 29, 2012 · 3 comments
Assignees
Labels
Type: Bug Issues reporting and PRs fixing problems

Comments

@Cervator
Copy link
Member

Found a few issues playing with the shiny new reflective water while merging in the changes from @overdhose that makes enabling it easy:

  1. Reflective water + heavy fog = unhappy shaders (or something). See example below - I should probably dig up some logs or something if possible?
  2. The side of reflective water is jealous of the top and also reflects ... the sky. Maybe side water should be either opaque or just transparent or something?
  3. Should / is it possible for the reflection to be less absolute and let a bit more of the scenery below water show?
  4. Looking at reflective water that looks "up" at blocks can seemingly look inside solid objects (looks similar to clipping into terrain and seeing only some rendered block sides with most invisible)

Pretty tho, and runs well on my system at least :D

foggy reflection

@ghost ghost assigned begla Jul 29, 2012
@mcourteaux
Copy link
Contributor

Pretty tho, and runs well on my system at least :D

Please, make this feature at least part of the rendering quality "epic", or maybe create an extra one :) To be part of "ugly" would kill lots of gpu's. Just saying, because I really like the game and I would hate it to become unable to play it because of the heavy graphics :)

@Cervator
Copy link
Member Author

It is actually a separate toggle from graphic quality entirely, and disabled by default :-)

@Cervator
Copy link
Member Author

Cervator commented Jan 4, 2013

Closing this as water reflection has recently gone through a bunch of nice tweaks :-)

@Cervator Cervator closed this as completed Jan 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

No branches or pull requests

3 participants